From: Bjorn Helgaas <helgaas@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: linux-pci@vger.kernel.org,
Mateusz Kaduk <mateusz.kaduk@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>, Tj <linux@iam.tj>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hans de Goede <hdegoede@redhat.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/1] x86/pci: Skip early E820 check for ECAM region
Date: Thu, 18 Apr 2024 12:10:11 -0500 [thread overview]
Message-ID: <20240418171011.GA243400@bhelgaas> (raw)
In-Reply-To: <11f55f7e-92f9-4689-9dd8-75fb45f8afe5@linux.intel.com>
On Wed, Apr 17, 2024 at 08:10:28PM -0700, Kuppuswamy Sathyanarayanan wrote:
>
> On 4/17/24 1:40 PM, Bjorn Helgaas wrote:
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > Arul, Mateusz, Imcarneiro91, and Aman reported a regression caused by
> > 07eab0901ede ("efi/x86: Remove EfiMemoryMappedIO from E820 map"). On the
> > Lenovo Legion 9i laptop, that commit removes the area containing ECAM from
> > E820, which means the early E820 validation started failing, which meant we
> > didn't enable ECAM in the "early MCFG" path
> ...
> LGTM
>
> Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Thanks for taking a look!
> > - if (!early && !acpi_disabled) {
> > + if (early) {
> > +
> > + /*
> > + * Don't try to do this check unless configuration type 1
> > + * is available. How about type 2?
>
> I don't understand why above question is included in the comment. Do
> you think it is better to drop that part of the comment?
The "How about type 2?" questio was added by bb63b4219976 ("x86 pci:
remove checking type for mmconfig probe"). I only moved it and fixed
the capitalization and formatting.
> > - /* Don't try to do this check unless configuration
> > - type 1 is available. how about type 2 ?*/
> > - if (raw_pci_ops)
> > - return is_mmconf_reserved(e820__mapped_all, cfg, dev,
> > - "E820 entry");
> > -
> > return false;
> > }
next prev parent reply other threads:[~2024-04-18 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 20:40 [PATCH 0/1] x86/pci: Skip early E820 check for ECAM region Bjorn Helgaas
2024-04-17 20:40 ` [PATCH 1/1] " Bjorn Helgaas
2024-04-17 20:47 ` Andy Shevchenko
2024-04-17 21:09 ` Bjorn Helgaas
2024-04-18 3:10 ` Kuppuswamy Sathyanarayanan
2024-04-18 17:10 ` Bjorn Helgaas [this message]
2024-04-18 8:14 ` Hans de Goede
2024-04-18 17:15 ` Bjorn Helgaas
2024-04-19 7:25 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240418171011.GA243400@bhelgaas \
--to=helgaas@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@iam.tj \
--cc=mateusz.kaduk@gmail.com \
--cc=mingo@redhat.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).