From: Vidya Sagar <vidyas@nvidia.com>
To: Zou Wei <zou_wei@huawei.com>, <thierry.reding@gmail.com>,
<lorenzo.pieralisi@arm.com>, <robh@kernel.org>,
<bhelgaas@google.com>, <jonathanh@nvidia.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE
Date: Thu, 13 May 2021 14:28:33 +0530 [thread overview]
Message-ID: <241d64eb-44e4-a838-a07a-8127c189a1c1@nvidia.com> (raw)
In-Reply-To: <1620792422-16535-1-git-send-email-zou_wei@huawei.com>
Thanks for the patch.
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
On 5/12/2021 9:37 AM, Zou Wei wrote:
> External email: Use caution opening links or attachments
>
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/pci/controller/pci-tegra.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c
> index 8069bd9..c979229 100644
> --- a/drivers/pci/controller/pci-tegra.c
> +++ b/drivers/pci/controller/pci-tegra.c
> @@ -2539,6 +2539,7 @@ static const struct of_device_id tegra_pcie_of_match[] = {
> { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
> { },
> };
> +MODULE_DEVICE_TABLE(of, tegra_pcie_of_match);
>
> static void *tegra_pcie_ports_seq_start(struct seq_file *s, loff_t *pos)
> {
> --
> 2.6.2
>
next prev parent reply other threads:[~2021-05-13 8:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 4:07 [PATCH -next] PCI: tegra: Add missing MODULE_DEVICE_TABLE Zou Wei
2021-05-13 8:58 ` Vidya Sagar [this message]
2021-06-01 17:04 ` Thierry Reding
2021-06-03 16:08 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=241d64eb-44e4-a838-a07a-8127c189a1c1@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).