From: John Garry <john.garry@huawei.com>
To: Olof Johansson <olof@lixom.net>, Wei Xu <xuwei5@hisilicon.com>
Cc: ARM-SoC Maintainers <arm@kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Arnd Bergmann <arnd@arndb.de>, Linuxarm <linuxarm@huawei.com>,
"xuwei (O)" <xuwei5@huawei.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
<linux-pci@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zhangyi ac <zhangyi.ac@huawei.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>,
<jinying@hisilicon.com>, huangdaode <huangdaode@hisilicon.com>,
Tangkunshan <tangkunshan@huawei.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>,
Shiju Jose <shiju.jose@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>
Subject: Re: [GIT PULL] Hisilicon fixes for v5.2
Date: Wed, 26 Jun 2019 16:21:56 +0100 [thread overview]
Message-ID: <2e59728e-25fa-cc15-3c63-3566dc2ae69f@huawei.com> (raw)
In-Reply-To: <7e215bd7-daab-b6cf-8d0f-9513bd7c4f6d@huawei.com>
On 25/06/2019 14:31, John Garry wrote:
> On 25/06/2019 14:03, Olof Johansson wrote:
>>>> are available in the Git repository at:
>>>> > >
>>>> > > git://github.com/hisilicon/linux-hisi.git tags/hisi-fixes-for-5.2
>>>> > >
>>>> > > for you to fetch changes up to
>>>> 07c811af1c00d7b4212eac86900b023b6405a954:
>>>> > >
>>>> > > lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set
>>>> at registration (2019-06-25 09:40:42 +0100)
>>>> > >
>>>> > > ----------------------------------------------------------------
>>>> > > Hisilicon fixes for v5.2-rc
>>>> > >
>>>> > > - fixed RCU usage in logical PIO
>>>> > > - Added a function to unregister a logical PIO range in logical PIO
>>>> > > to support the fixes in the hisi-lpc driver
>>>> > > - fixed and optimized hisi-lpc driver to avoid potential
>>>> use-after-free
>>>> > > and driver unbind crash
>>> >
>>> > Merged to fixes, thanks.
>>
>> This broke arm64 allmodconfig:
>>
>> arm64.allmodconfig:
>> drivers/bus/hisi_lpc.c:656:3: error: implicit declaration of function
>> 'hisi_lpc_acpi_remove'; did you mean 'hisi_lpc_acpi_probe'?
>> [-Werror=implicit-function-declaration]
As an aside, I find it a little strange that arm64 allmodconfig does not
have CONFIG_ACPI set. It used to have it set, and this patch stopped that:
5bcd44083a082f314032969cd6db1eb8275ac77a is the first bad commit
commit 5bcd44083a082f314032969cd6db1eb8275ac77a
Author: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Mon Jul 23 10:57:29 2018 +0900
drivers: acpi: add dependency of EFI for arm64
As Ard suggested, CONFIG_ACPI && !CONFIG_EFI doesn't make sense on
arm64,
while CONFIG_ACPI and CONFIG_CPU_BIG_ENDIAN doesn't make sense either.
As CONFIG_EFI already has a dependency of !CONFIG_CPU_BIG_ENDIAN, it is
good enough to add a dependency of CONFIG_EFI to avoid any useless
combination of configuration.
This bug, reported by Will, will be revealed when my patch series,
"arm64: kexec,kdump: fix boot failures on acpi-only system," is applied
and the kernel is built under allmodconfig.
Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Suggested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
That patch stopped many configs being set for allmodconfig.
With this change, CONFIG_EFI is not set. I think that this is because
CONFIG_CPU_BIG_ENDIAN is set for arm64 allmodconfig.
Any opinion on this? Could we change CONFIG_CPU_BIG_ENDIAN to be unset
for arm64?
>>
>>
>
> Uhhh, that's my fault - I didn't provide a stub for !ACPI. Sorry. I'll
> send a fixed v3 series.
>
>>
>> Please build and test your branches before you send pull requests, Wei.
>>
>> I've dropped the branch again; please re-submit when fixed. I think
>> it's probably 5.3 material now.
>>
>
> Thanks,
> John
>
>>
>> -Olof
>>
>> .
>>
>
next prev parent reply other threads:[~2019-06-26 15:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 10:23 [GIT PULL] Hisilicon fixes for v5.2 Wei Xu
2019-06-25 10:39 ` Wei Xu
2019-06-25 10:44 ` John Garry
2019-06-25 11:21 ` Olof Johansson
2019-06-25 13:03 ` Olof Johansson
2019-06-25 13:31 ` John Garry
2019-06-26 15:21 ` John Garry [this message]
2019-06-27 2:19 ` Olof Johansson
2019-07-01 6:22 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e59728e-25fa-cc15-3c63-3566dc2ae69f@huawei.com \
--to=john.garry@huawei.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=huangdaode@hisilicon.com \
--cc=jinying@hisilicon.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=olof@lixom.net \
--cc=rjw@rjwysocki.net \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shiju.jose@huawei.com \
--cc=tangkunshan@huawei.com \
--cc=xuwei5@hisilicon.com \
--cc=xuwei5@huawei.com \
--cc=zhangyi.ac@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).