From: Vidya Sagar <vidyas@nvidia.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: <linux-pci@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH -next] PCI: tegra: Fix the error return code in tegra_pcie_dw_probe()
Date: Thu, 22 Aug 2019 09:48:28 +0530 [thread overview]
Message-ID: <3038da4d-154a-16a8-4a1f-4dcce3e93cb8@nvidia.com> (raw)
In-Reply-To: <20190822020352.35412-1-weiyongjun1@huawei.com>
On 8/22/2019 7:33 AM, Wei Yongjun wrote:
> Fix the error return code in tegra_pcie_dw_probe() by using error code
> instead of PTR_ERR(NULL) which is always 0.
>
> Fixes: 6404441c8e13 ("PCI: tegra: Add Tegra194 PCIe support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/pci/controller/dwc/pcie-tegra194.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c
> index fc0dbeb31d78..678a6b51c7aa 100644
> --- a/drivers/pci/controller/dwc/pcie-tegra194.c
> +++ b/drivers/pci/controller/dwc/pcie-tegra194.c
> @@ -1384,7 +1384,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
> "appl");
> if (!pcie->appl_res) {
> dev_err(dev, "Failed to find \"appl\" region\n");
> - return PTR_ERR(pcie->appl_res);
> + return -ENODEV;
> }
>
> pcie->appl_base = devm_ioremap_resource(dev, pcie->appl_res);
> @@ -1400,7 +1400,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
>
> phys = devm_kcalloc(dev, pcie->phy_count, sizeof(*phys), GFP_KERNEL);
> if (!phys)
> - return PTR_ERR(phys);
> + return -ENOMEM;
>
> for (i = 0; i < pcie->phy_count; i++) {
> name = kasprintf(GFP_KERNEL, "p2u-%u", i);
> @@ -1422,7 +1422,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
> dbi_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dbi");
> if (!dbi_res) {
> dev_err(dev, "Failed to find \"dbi\" region\n");
> - return PTR_ERR(dbi_res);
> + return -ENODEV;
> }
> pcie->dbi_res = dbi_res;
>
> @@ -1437,7 +1437,7 @@ static int tegra_pcie_dw_probe(struct platform_device *pdev)
> "atu_dma");
> if (!atu_dma_res) {
> dev_err(dev, "Failed to find \"atu_dma\" region\n");
> - return PTR_ERR(atu_dma_res);
> + return -ENODEV;
> }
> pcie->atu_dma_res = atu_dma_res;
>
Thanks for pushing this change.
BTW, did you use any infrastructure to simulate missing entries in device-tree to
see if the driver is returning error or not? Or you found out by just reviewing the code?
Reviewed-by: Vidya Sagar <vidyas@nvidia.com>
>
>
next prev parent reply other threads:[~2019-08-22 4:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-22 2:03 [PATCH -next] PCI: tegra: Fix the error return code in tegra_pcie_dw_probe() Wei Yongjun
2019-08-22 4:18 ` Vidya Sagar [this message]
2019-08-22 9:54 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3038da4d-154a-16a8-4a1f-4dcce3e93cb8@nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=thierry.reding@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).