From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC5E5C282C2 for ; Fri, 8 Feb 2019 01:58:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A6DAD21917 for ; Fri, 8 Feb 2019 01:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549591124; bh=b+S0EFJwpzXXcIXWxFeOomz6lpqOHYC0b0kUYWYGRA8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=AqrP6fvb9l4cjdod+1TZ0tWJnogjzNnAb1I6lbE7y6LxfZGZvw3GaE4hrfrezXSG/ Xf/yQam6VES4fDnSD8F5rNlcHItSMFI2Q78E4/apyE6mOnounLXKN3+/2qJfViRI2z FhaIEUesX3YkqSMBIF8JP9PCejtJzeo16s8Smzcw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbfBHB6o (ORCPT ); Thu, 7 Feb 2019 20:58:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:33358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726775AbfBHB6n (ORCPT ); Thu, 7 Feb 2019 20:58:43 -0500 Received: from [192.168.0.111] (cpe-174-109-247-98.nc.res.rr.com [174.109.247.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 34D392146E; Fri, 8 Feb 2019 01:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549591123; bh=b+S0EFJwpzXXcIXWxFeOomz6lpqOHYC0b0kUYWYGRA8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=usPhDr1O+l4a3klZTbUJ0A9BEKhuoIZFHh9uiWLwFA3P3AIcYFF5MwksHmTYiDNm6 TfeXStxaysaSU7ijbogjWVVNBbRKmXoWmp72i5vgJ6RyFELSrkBmhYaQpglf7EuubZ 8WIuYi2xt5ZamT2+izszlEl9ZPp/BVWlYiQ9PiNw= Subject: Re: [PATCH v1 1/2] PCI: ATS: Add function to check ATS page aligned request status. To: sathyanarayanan.kuppuswamy@linux.intel.com, bhelgaas@google.com, joro@8bytes.org, dwmw2@infradead.org Cc: linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Ashok Raj , Jacob Pan , Keith Busch References: <91bfae8b1d4b424219e3ce3c1fc03559c73f1ae7.1549478584.git.sathyanarayanan.kuppuswamy@linux.intel.com> <5d55e369-355f-b710-0594-03465aa985da@kernel.org> From: Sinan Kaya Message-ID: <32ec3293-28ea-8f0f-f801-0370b4cf0453@kernel.org> Date: Thu, 7 Feb 2019 20:58:39 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2/7/2019 5:16 PM, sathyanarayanan kuppuswamy wrote: >> If I remember this right, aligned request is only supported on ATS v1.1 >> but not supported on v1.0. > Its added in v1.1. This means that you should probably have some kind of version check here.