From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF2C9C433C1 for ; Fri, 26 Mar 2021 00:59:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BAEE61A38 for ; Fri, 26 Mar 2021 00:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbhCZA7F (ORCPT ); Thu, 25 Mar 2021 20:59:05 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:14904 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229933AbhCZA6i (ORCPT ); Thu, 25 Mar 2021 20:58:38 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F63TG0hWkzkfrd; Fri, 26 Mar 2021 08:56:50 +0800 (CST) Received: from [10.174.177.160] (10.174.177.160) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Fri, 26 Mar 2021 08:58:25 +0800 Subject: Re: [PATCH 2/4] PCI/AER: Correct function names in the header To: "Rafael J. Wysocki" CC: Bjorn Helgaas , "Rafael J. Wysocki" , , Linux PCI , ACPI Devel Maling List , Linux Kernel Mailing List References: <20210325075144.180030-1-wangxiongfeng2@huawei.com> <20210325075144.180030-3-wangxiongfeng2@huawei.com> From: Xiongfeng Wang Message-ID: <39a66394-cd74-ebff-7447-cb9fa51d8db4@huawei.com> Date: Fri, 26 Mar 2021 08:58:24 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.160] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Rafael, On 2021/3/26 1:30, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:50 AM Xiongfeng Wang > wrote: >> >> Fixes the following W=1 kernel build warning(s): >> >> drivers/pci/pcie/aer.c:138: warning: expecting prototype for enable_ercr_checking(). Prototype was for enable_ecrc_checking() instead >> drivers/pci/pcie/aer.c:162: warning: expecting prototype for disable_ercr_checking(). Prototype was for disable_ecrc_checking() instead >> drivers/pci/pcie/aer.c:1450: warning: expecting prototype for aer_service_init(). Prototype was for pcie_aer_init() instead >> >> Reported-by: Hulk Robot >> Signed-off-by: Xiongfeng Wang > > The subject is somewhat inaccurate, because you're fixing function > names in kerneldoc comments. > > If you say "a header", people may think that this is about a header file. Thanks a lot ! I will change it in the next version. Thanks, Xiongfeng > >> --- >> drivers/pci/pcie/aer.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c >> index ba22388342d1..ec943cee5ecc 100644 >> --- a/drivers/pci/pcie/aer.c >> +++ b/drivers/pci/pcie/aer.c >> @@ -129,7 +129,7 @@ static const char * const ecrc_policy_str[] = { >> }; >> >> /** >> - * enable_ercr_checking - enable PCIe ECRC checking for a device >> + * enable_ecrc_checking - enable PCIe ECRC checking for a device >> * @dev: the PCI device >> * >> * Returns 0 on success, or negative on failure. >> @@ -153,7 +153,7 @@ static int enable_ecrc_checking(struct pci_dev *dev) >> } >> >> /** >> - * disable_ercr_checking - disables PCIe ECRC checking for a device >> + * disable_ecrc_checking - disables PCIe ECRC checking for a device >> * @dev: the PCI device >> * >> * Returns 0 on success, or negative on failure. >> @@ -1442,7 +1442,7 @@ static struct pcie_port_service_driver aerdriver = { >> }; >> >> /** >> - * aer_service_init - register AER root service driver >> + * pcie_aer_init - register AER root service driver >> * >> * Invoked when AER root service driver is loaded. >> */ >> -- >> 2.20.1 >> > . >