From: Arnd Bergmann <arnd@arndb.de>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: devicetree@vger.kernel.org,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Magnus Damm <damm@opensource.se>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Ben Dooks <ben.dooks@codethink.co.uk>,
linux-pci@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH] of/irq: provide int of_irq_parse_and_map_pci wrapper
Date: Fri, 09 May 2014 10:45:53 +0200 [thread overview]
Message-ID: <4975430.zMeeu7d2Xc@wuerfel> (raw)
In-Reply-To: <1399624119.4833.3.camel@weser.hi.pengutronix.de>
On Friday 09 May 2014 10:28:39 Lucas Stach wrote:
> Am Freitag, den 09.05.2014, 08:58 +0200 schrieb Arnd Bergmann:
> > The pci-rcar driver is enabled for compile tests, and this has
> > now shown that the driver cannot build without CONFIG_OF,
> > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF
> > interrupt mapping when possible":
> >
> > drivers/built-in.o: In function `rcar_pci_map_irq':
> > :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci'
> >
> > As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually
> > supposed to build fine, which we can achieve if we make the
> > declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF
> > and provide an empty inline function otherwise, as we do for
> > a lot of other of interfaces.
> >
> > This lets us build the rcar_pci driver again without CONFIG_OF,
> > which won't work but give us compile time coverage.
> >
> This part of the commit message is confusing. The driver is explicitly
> written to fall back to a platform irq when OF interrupt mapping doesn't
> work (return 0 or error), to keep non DT enabled boards working.
>
> I hadn't thought of the compile time dependency, so thanks for fixing
> this up.
I thought it was meant to keep old DTBs working. AFAIK, there is no
legacy board file support for rcar-gen2, so we don't actually have to
worry about that.
Arnd
next prev parent reply other threads:[~2014-05-09 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 6:58 [PATCH] of/irq: provide int of_irq_parse_and_map_pci wrapper Arnd Bergmann
2014-05-09 7:11 ` Geert Uytterhoeven
2014-05-09 8:28 ` Lucas Stach
2014-05-09 8:45 ` Arnd Bergmann [this message]
2014-05-09 8:54 ` Lucas Stach
2014-05-09 8:56 ` Geert Uytterhoeven
2014-05-09 9:03 ` [PATCH v2] " Arnd Bergmann
2014-05-09 9:09 ` Geert Uytterhoeven
2014-05-28 1:35 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4975430.zMeeu7d2Xc@wuerfel \
--to=arnd@arndb.de \
--cc=ben.dooks@codethink.co.uk \
--cc=bhelgaas@google.com \
--cc=damm@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=grant.likely@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).