From: Shuah Khan <skhan@linuxfoundation.org>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
Puranjay Mohan <puranjay12@gmail.com>,
Bjorn Helgaas <bjorn@helgaas.com>,
stephen@networkplumber.org,
"David S. Miller" <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 10:36:02 -0600 [thread overview]
Message-ID: <5f04f52d-8911-4db9-4321-00334d357d54@linuxfoundation.org> (raw)
In-Reply-To: <20190621162024.53620dd9@alans-desktop>
On 6/21/19 9:20 AM, Alan Cox wrote:
> On Fri, 21 Jun 2019 15:16:04 +0530
> Puranjay Mohan <puranjay12@gmail.com> wrote:
>
>> This patch series removes the private duplicates of PCI definitions in
>> favour of generic definitions defined in pci_regs.h.
>
> Why bother ? It's an ancient obsolete card ?
>
> Do you even have one to test ?
>
>>
>> This driver only uses some of the generic PCI definitons,
>> which are included from pci_regs.h and thier private versions
>> are removed from skfbi.h with all other private defines.
>>
>> The skfbi.h defines PCI_REV_ID and other private defines with different
>> names, these are renamed to Generic PCI names to make them
>> compatible with defines in pci_regs.h.
>>
>> All unused defines are removed from skfbi.h.
>
> I sincerely doubt anyone on the planet is using this card any more.
>
> Alan
>
Thanks Alan!
Stephen Hemminger is suggesting removal as well. Makes sense to me.
David!
What would you recommend the next steps are? Would like driver removed?
thanks,
-- Shuah
next prev parent reply other threads:[~2019-06-21 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:46 [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 1/3] net: fddi: skfp: Rename local PCI defines to match generic PCI defines Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 2/3] net: fddi: skfp: Include generic PCI definitions Puranjay Mohan
2019-06-21 9:46 ` [PATCH v3 3/3] net: fddi: skfp: Remove unused private " Puranjay Mohan
2019-06-21 14:05 ` [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Bjorn Helgaas
2019-06-21 15:20 ` Alan Cox
2019-06-21 16:36 ` Shuah Khan [this message]
2019-06-26 20:03 ` David Miller
2019-06-21 16:44 ` Bjorn Helgaas
2019-06-21 17:59 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f04f52d-8911-4db9-4321-00334d357d54@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=bjorn@helgaas.com \
--cc=davem@davemloft.net \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).