From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: Martin Kaiser <martin@kaiser.cx>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: brcmstb: Fix race in removing chained IRQ handler
Date: Thu, 12 Nov 2020 10:07:25 +0100 [thread overview]
Message-ID: <77ba062d8ce103db81fcc7ac8b802e1b54befda8.camel@suse.de> (raw)
In-Reply-To: <20201111215354.21961-1-martin@kaiser.cx>
[-- Attachment #1: Type: text/plain, Size: 1174 bytes --]
On Wed, 2020-11-11 at 22:53 +0100, Martin Kaiser wrote:
> Call irq_set_chained_handler_and_data() to clear the chained handler
> and the handler's data under irq_desc->lock.
>
> See also 2cf5a03cb29d ("PCI/keystone: Fix race in installing chained
> IRQ handler").
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Thanks!
> v2:
> - rewrite the commit message to clarify that this is a bugfix
>
> drivers/pci/controller/pcie-brcmstb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
> index bea86899bd5d..7c666f4deb47 100644
> --- a/drivers/pci/controller/pcie-brcmstb.c
> +++ b/drivers/pci/controller/pcie-brcmstb.c
> @@ -606,8 +606,7 @@ static void brcm_msi_remove(struct brcm_pcie *pcie)
>
> if (!msi)
> return;
> - irq_set_chained_handler(msi->irq, NULL);
> - irq_set_handler_data(msi->irq, NULL);
> + irq_set_chained_handler_and_data(msi->irq, NULL, NULL);
> brcm_free_domains(msi);
> }
>
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-12 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 18:42 [PATCH] PCI: brcmstb: Remove irq handler and data in one go Martin Kaiser
2020-11-09 2:00 ` Florian Fainelli
2020-11-11 21:53 ` [PATCH v2] PCI: brcmstb: Fix race in removing chained IRQ handler Martin Kaiser
2020-11-12 9:07 ` Nicolas Saenz Julienne [this message]
2020-11-12 22:03 ` [PATCH v3] PCI: brcmstb: remove chained IRQ handler and data in one go Martin Kaiser
2021-01-15 21:15 ` [PATCH v4] PCI: brcmstb: Remove " Martin Kaiser
2021-01-19 12:24 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77ba062d8ce103db81fcc7ac8b802e1b54befda8.camel@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).