From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>, Kishon Vijay Abraham I <kishon@ti.com>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: pci-usb/pci-sata broken with LPAE config after "reduce use of block bounce buffers"
Date: Mon, 18 Nov 2019 17:21:37 +0000 [thread overview]
Message-ID: <872a502c-5921-2b2e-de65-afc524f156c7@arm.com> (raw)
In-Reply-To: <20191116163528.GE23951@lst.de>
On 16/11/2019 4:35 pm, Christoph Hellwig wrote:
> On Fri, Nov 15, 2019 at 07:48:23PM +0530, Kishon Vijay Abraham I wrote:
>> I think the fix on 5.3 was useful for platform drivers (where the platform
>> driver will set dma_set_mask as 32bits) even when the system itself supports LPAE.
>
> Well, we can also use the bus_dma_mask for PCI(e) root port quirks,
> as we do that for the VIA ones on x86. But I think the OF parsing code
> is missing something here, and Robin did plan to look into that.
Right, the correct way to describe this is with "dma-ranges" on the host
bridge node, and there are patches queued in linux-next to (finally)
handle that properly for the way we bodge dynamically-discovered
endpoints through of_dma_configure().
Robin.
>> We should find a way to set the DMA mask of of the PCI device based on the DMA
>> mask of the PCI controller in the SoC. One option would be to change the
>> pci_drivers all over the kernel to set DMA mask to be based on the DMA mask of
>> the PCI controller (the PCI device hierarchy should get a reference to the
>> device pointer of the PCI controller). Or is there a better way to handle this?
>
> No. The driver sets the device capabilities. bus_dma_mask handles
> the system limitations.
>
next prev parent reply other threads:[~2019-11-18 17:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 10:59 pci-usb/pci-sata broken with LPAE config after "reduce use of block bounce buffers" Kishon Vijay Abraham I
2019-11-15 13:06 ` Christoph Hellwig
2019-11-15 14:18 ` Kishon Vijay Abraham I
2019-11-16 16:35 ` Christoph Hellwig
2019-11-18 17:21 ` Robin Murphy [this message]
2019-11-25 5:43 ` Kishon Vijay Abraham I
2020-01-27 13:10 ` Kishon Vijay Abraham I
2020-01-27 13:22 ` Robin Murphy
2020-01-29 6:24 ` Kishon Vijay Abraham I
2020-01-30 7:58 ` Christoph Hellwig
2020-01-30 8:09 ` Kishon Vijay Abraham I
2020-01-30 16:42 ` Christoph Hellwig
2020-01-31 11:44 ` Kishon Vijay Abraham I
2020-02-03 14:21 ` Christoph Hellwig
2020-02-05 5:15 ` Kishon Vijay Abraham I
2020-02-05 7:47 ` Christoph Hellwig
2020-02-05 8:32 ` Kishon Vijay Abraham I
2020-02-05 8:48 ` Christoph Hellwig
2020-02-05 9:18 ` Kishon Vijay Abraham I
2020-02-05 9:19 ` Christoph Hellwig
2020-02-05 9:33 ` Kishon Vijay Abraham I
2020-02-05 16:05 ` Christoph Hellwig
2020-02-17 14:23 ` Christoph Hellwig
2020-02-18 12:15 ` Kishon Vijay Abraham I
2020-04-02 12:01 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=872a502c-5921-2b2e-de65-afc524f156c7@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).