From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8A2C35280 for ; Fri, 8 May 2020 02:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 86D9C208D6 for ; Fri, 8 May 2020 02:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726598AbgEHCdI (ORCPT ); Thu, 7 May 2020 22:33:08 -0400 Received: from mga03.intel.com ([134.134.136.65]:24675 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726542AbgEHCdH (ORCPT ); Thu, 7 May 2020 22:33:07 -0400 IronPort-SDR: JpiOjZMAx1VEWhrhxW4tw7+sd4lWd6sXOwmh6NGR9JE5J9gupi4oAS2DjX7mpO6TmqZnxc+26x 8loIe/BBEdzQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 19:33:07 -0700 IronPort-SDR: VkCetOwwKVpAsN2JwLOJxdE/61ZHx0CBjsTOcR3Tgjurdg2otwHp/i5NsiTDtVcojYr1Dlv98H ZZNBXjGAHwnQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="278805860" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 07 May 2020 19:33:07 -0700 Received: from debox1-desk1.jf.intel.com (debox1-desk1.jf.intel.com [10.7.201.137]) by linux.intel.com (Postfix) with ESMTP id 652CE580609; Thu, 7 May 2020 19:33:07 -0700 (PDT) Message-ID: <9c46a0be9c6d2097df1523711b33b0b7094a5ce4.camel@linux.intel.com> Subject: Re: [PATCH 3/3] platform/x86: Intel PMT Telemetry capability driver From: "David E. Box" Reply-To: david.e.box@linux.intel.com To: Andy Shevchenko Cc: Bjorn Helgaas , Andy Shevchenko , alexander.h.duyck@intel.com, Linux Kernel Mailing List , linux-pci@vger.kernel.org, Alexander Duyck Date: Thu, 07 May 2020 19:33:07 -0700 In-Reply-To: References: <20200505013206.11223-1-david.e.box@linux.intel.com> <20200505023149.11630-1-david.e.box@linux.intel.com> <20200505023149.11630-2-david.e.box@linux.intel.com> Organization: David E. Box Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, 2020-05-05 at 16:49 +0300, Andy Shevchenko wrote: > ... > > > + /* TODO: replace with device properties??? */ > > So, please, fulfill. swnode I guess is what you are looking for. I kept the platform data in v2 because swnode properties doesn't look like a good fit. We are only passing information that was read from the pci device. It is not hard coded, platform specific data. David