From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAE30C433DF for ; Wed, 22 Jul 2020 18:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 888D620B1F for ; Wed, 22 Jul 2020 18:07:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VQOOnqg7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726649AbgGVSH1 (ORCPT ); Wed, 22 Jul 2020 14:07:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726666AbgGVSH1 (ORCPT ); Wed, 22 Jul 2020 14:07:27 -0400 Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 175F5C0619E2 for ; Wed, 22 Jul 2020 11:07:27 -0700 (PDT) Received: by mail-ed1-x544.google.com with SMTP id dg28so2353432edb.3 for ; Wed, 22 Jul 2020 11:07:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FdyJ3zCjPfmLPOxt0EpbJoGI3z0Dst2ftnMjMBs721s=; b=VQOOnqg73U7x3eQrsDW5P6NHQpsRTrBV6mDqQ35Y7KbR5dxMVHVEhlOpBKgbC4YauI hKoPoQogS3yVaVz+cHKlmtCp41T1+KI57s1dNmREFvPgWO9LQa1Md2XUbvuoYp7xcDOD uJkxpr/ugST6O4YCQmPPrAz4f1LYvrnmu4TBkKKzuhd7zdw95+t6HeiJXKW9A6c8pPUy XRNlbkclQcCrxbPIAZrisC31UWn7W4GKg1hOvR+OFZqdAhucXRldSHGUkEO+NbUB9S9S XaVu2nmp3aY/+8g9/c/Kskh84nH4FtiosOyHuJCZKQY+DsufHyQlBrv/tBuyO6TpzdFa UM+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FdyJ3zCjPfmLPOxt0EpbJoGI3z0Dst2ftnMjMBs721s=; b=bKpA1gZfurAz7D3YQSa6SBMLMi3bgYEgq5C+ceeKdW2tYd7Z6ASHkcWQnAK72bthY5 Dyixy82MF5lO1fyQTLMQA0H6bUSog8Uc6qcvxxMyHkmeNgLSLEYSMwsvTxNoI3elesvD 5W7Qwdh0B5HG9DWgXQ9sbL4d2ZLA6Oap96WrK17x+hRxd5Jsf+gwdKoheGivEXU6WbfA idLQNfMvBvFvIRzVOccoKldp4hGaphcaPzDD7CXRD6Tucexxk8HEHXOkuxvU3qP1wOIh pssmAwTMcUWnW6o0jrf8FP8DtduEuVj2CxxVZZw4xmiHvSQbmoOGdaMmJC8LmlU96upA BJnQ== X-Gm-Message-State: AOAM5338pjFOzpdApH2IP8l6Zt/mjefFAucU4wgjZY2L4SCo9Aicf0XH AHrIGb+bNu/jLlEx9r8EZ9Uev0DPTQarcfoMWRZ1uQ== X-Google-Smtp-Source: ABdhPJwcnL9bpNsR0ioOLFXQ9M3j8q0lz48Fhhhje9z+wnEe4/R/foPMYkXV+6IoYiAKnIEt8CMey3jrAzyf6UdUmaI= X-Received: by 2002:a05:6402:542:: with SMTP id i2mr682149edx.318.1595441245286; Wed, 22 Jul 2020 11:07:25 -0700 (PDT) MIME-Version: 1.0 References: <20200624203200.78870-1-samitolvanen@google.com> <20200624203200.78870-5-samitolvanen@google.com> <20200624212737.GV4817@hirez.programming.kicks-ass.net> <20200624214530.GA120457@google.com> <20200625074530.GW4817@hirez.programming.kicks-ass.net> <20200625161503.GB173089@google.com> <20200625200235.GQ4781@hirez.programming.kicks-ass.net> <20200625224042.GA169781@google.com> <20200626112931.GF4817@hirez.programming.kicks-ass.net> <20200717133645.7816c0b6@oasis.local.home> <20200717140545.6f008208@oasis.local.home> <20200722135829.7ca6fbc5@oasis.local.home> In-Reply-To: <20200722135829.7ca6fbc5@oasis.local.home> From: Sami Tolvanen Date: Wed, 22 Jul 2020 11:07:13 -0700 Message-ID: Subject: Re: [RFC][PATCH] objtool,x86_64: Replace recordmcount with objtool To: Steven Rostedt Cc: Peter Zijlstra , Masahiro Yamada , Will Deacon , Greg Kroah-Hartman , "Paul E. McKenney" , Kees Cook , Nick Desaulniers , clang-built-linux , Kernel Hardening , linux-arch , linux-arm-kernel , linux-kbuild , LKML , linux-pci@vger.kernel.org, X86 ML , Josh Poimboeuf Content-Type: text/plain; charset="UTF-8" Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jul 22, 2020 at 10:58 AM Steven Rostedt wrote: > > On Mon, 20 Jul 2020 09:52:37 -0700 > Sami Tolvanen wrote: > > > > Does x86 have a way to differentiate between the two that record mcount > > > can check? > > > > I'm not sure if looking at the relocation alone is sufficient on x86, > > we might also have to decode the instruction, which is what objtool > > does. Did you have any thoughts on Peter's patch, or my initial > > suggestion, which adds a __nomcount attribute to affected functions? > > There's a lot of code in this thread. Can you give me the message-id of > Peter's patch in question. Sure, I was referring to the objtool patch in this message: https://lore.kernel.org/lkml/20200625200235.GQ4781@hirez.programming.kicks-ass.net/ Sami