From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Mark Brown <broonie@kernel.org>, Felipe Balbi <balbi@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v1] PCI: Move Rohm vendor ID to generic list
Date: Thu, 8 Nov 2018 14:19:12 +0200 [thread overview]
Message-ID: <CAHp75Vf7YJ=Yzo51yw1J+K2irshqve0rr6RN0UqneXCo7aRVCA@mail.gmail.com> (raw)
In-Reply-To: <20181108100555.GB27328@kroah.com>
On Thu, Nov 8, 2018 at 12:10 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Nov 07, 2018 at 09:58:56PM +0200, Andy Shevchenko wrote:
> > Move the Rohm vendor ID to pci_ids.h from dozen of drivers.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >
> > I believe the best chance to get it merged and be less intrusive to ongoing
> > work is through PCI subsystem as a _fix_ for v4.20.
>
> What? Why? Who cares?
> This can trickle in over the next year or never, as it isn't a bugfix,
> or "necessary" at all. Just add it to pci_ids.h and when that gets
> merged, you can try to remove it from the individual drivers if it
> really is annoying to you.
>
> But this is _NOT_ a fix for anything, don't try to mask it as one, that
> feels like "crying wolf" here :(
It doesn't fix anything, indeed. But since it touches 9 drivers
simultaneously, it might be easier to push it earlier, or other way
around — at the end of the cycle.
OTOH, I don't think there would be conflicts if it goes normal way
through PCI subsystem.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-11-08 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:58 [PATCH v1] PCI: Move Rohm vendor ID to generic list Andy Shevchenko
2018-11-08 10:05 ` Greg Kroah-Hartman
2018-11-08 12:19 ` Andy Shevchenko [this message]
2018-11-08 14:34 ` Mark Brown
2018-11-15 11:08 ` Linus Walleij
2019-02-01 23:31 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vf7YJ=Yzo51yw1J+K2irshqve0rr6RN0UqneXCo7aRVCA@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).