From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Robin Murphy <robin.murphy@arm.com>
Cc: linux-pci <linux-pci@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
Graeme Gregory <graeme.gregory@linaro.org>,
Marc Zyngier <marc.zyngier@arm.com>,
Jingoo Han <jingoohan1@gmail.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Bjorn Helgaas <bhelgaas@google.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/3] pci: designware: add separate driver for the MSI part of the RC
Date: Thu, 24 Aug 2017 17:50:11 +0100 [thread overview]
Message-ID: <CAKv+Gu-mxLnnrZ58PR1hfcBScddewQ8rT77b0fRDnHVViu2WiQ@mail.gmail.com> (raw)
In-Reply-To: <e1f5e20d-929f-db8d-1c60-181698e678f0@arm.com>
On 24 August 2017 at 17:48, Robin Murphy <robin.murphy@arm.com> wrote:
> Hi Ard,
>
> On 21/08/17 20:29, Ard Biesheuvel wrote:
> [...]
>> +static int dw_pcie_msi_probe(struct platform_device *pdev)
>> +{
>> + struct fwnode_handle *fwnode = of_node_to_fwnode(pdev->dev.of_node);
>
> Mini-nit: since fairly recently (f94277af03ea) dev->fwnode should
> already be set appropriately by of_platform_device_create(), so you
> should be able to make this entirely firmware-agnostic if you like.
>
Thanks for pointing that out. I'm not sure yet what it means exactly,
but I'm sure I will figure it out :-)
next prev parent reply other threads:[~2017-08-24 16:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-21 19:29 [PATCH 0/3] pci: add support for firmware initialized designware RCs Ard Biesheuvel
2017-08-21 19:29 ` [PATCH 1/3] pci: designware: add driver for DWC controller in ECAM shift mode Ard Biesheuvel
2017-08-24 16:24 ` kbuild test robot
2017-08-24 16:25 ` kbuild test robot
2017-08-21 19:29 ` [PATCH 2/3] pci: designware: add separate driver for the MSI part of the RC Ard Biesheuvel
2017-08-24 16:42 ` Bjorn Helgaas
2017-08-24 16:43 ` Ard Biesheuvel
2017-08-24 16:48 ` Robin Murphy
2017-08-24 16:50 ` Ard Biesheuvel [this message]
2020-02-15 0:54 ` Alan Mikhak
2020-02-15 9:35 ` Ard Biesheuvel
2020-02-15 10:36 ` Marc Zyngier
2020-02-18 19:09 ` Alan Mikhak
2020-02-19 8:11 ` Marc Zyngier
2020-02-19 8:17 ` Ard Biesheuvel
2020-02-19 20:24 ` Alan Mikhak
2020-02-19 21:06 ` Ard Biesheuvel
2020-02-19 21:35 ` Alan Mikhak
2017-08-21 19:29 ` [PATCH 3/3] dt-bindings: designware: add binding for Designware PCIe in ECAM mode Ard Biesheuvel
2017-08-24 16:46 ` [PATCH 0/3] pci: add support for firmware initialized designware RCs Bjorn Helgaas
2017-08-31 19:21 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu-mxLnnrZ58PR1hfcBScddewQ8rT77b0fRDnHVViu2WiQ@mail.gmail.com \
--to=ard.biesheuvel@linaro.org \
--cc=Joao.Pinto@synopsys.com \
--cc=bhelgaas@google.com \
--cc=graeme.gregory@linaro.org \
--cc=jingoohan1@gmail.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).