From: Frank Li <frank.li@nxp.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Ren Zhijie <renzhijie2@huawei.com>,
"kishon@ti.com" <kishon@ti.com>,
"lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"jdmason@kudzu.us" <jdmason@kudzu.us>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH -next] NTB: EPF: Fix Kconfig dependency
Date: Thu, 23 Jun 2022 15:58:33 +0000 [thread overview]
Message-ID: <PAXPR04MB91865EE1D156F47DB8D9EE4B88B59@PAXPR04MB9186.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20220623155524.GA1452766@bhelgaas>
> -----Original Message-----
> From: Bjorn Helgaas <helgaas@kernel.org>
> Sent: Thursday, June 23, 2022 10:55 AM
> To: Frank Li <frank.li@nxp.com>
> Cc: Ren Zhijie <renzhijie2@huawei.com>; kishon@ti.com;
> lpieralisi@kernel.org; kw@linux.com; bhelgaas@google.com;
> jdmason@kudzu.us; linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH -next] NTB: EPF: Fix Kconfig dependency
>
> Caution: EXT Email
>
> On Thu, Jun 23, 2022 at 03:36:38PM +0000, Frank Li wrote:
> > > -----Original Message-----
> > > From: Ren Zhijie <renzhijie2@huawei.com>
> > > Sent: Thursday, June 23, 2022 3:46 AM
> > > To: kishon@ti.com; lpieralisi@kernel.org; kw@linux.com;
> > > bhelgaas@google.com; jdmason@kudzu.us; Frank Li <frank.li@nxp.com>
> > > Cc: linux-pci@vger.kernel.org; linux-kernel@vger.kernel.org; Ren Zhijie
> > > <renzhijie2@huawei.com>
> > > Subject: [PATCH -next] NTB: EPF: Fix Kconfig dependency
>
> @Ren, please use a typical subject line for the file, e.g.,
>
> PCI: endpoint: ...
>
> > > If CONFIG_NTB is not set and CONFIG_PCI_EPF_VNTB is y.
> > >
> > > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed,
> like
> > > this:
> > >
> > > drivers/pci/endpoint/functions/pci-epf-vntb.o: In function
> > > `epf_ntb_cmd_handler':
> > > pci-epf-vntb.c:(.text+0x95e): undefined reference to `ntb_db_event'
> > > pci-epf-vntb.c:(.text+0xa1f): undefined reference to `ntb_link_event'
> > > pci-epf-vntb.c:(.text+0xa42): undefined reference to `ntb_link_event'
> > > drivers/pci/endpoint/functions/pci-epf-vntb.o: In function
> `pci_vntb_probe':
> > > pci-epf-vntb.c:(.text+0x1250): undefined reference to
> `ntb_register_device'
> > >
> > > The functions ntb_*() are defined in drivers/ntb/core.c, which need
> > > CONFIG_NTB setting y to be build-in.
> > > To fix this build error, add depends on NTB.
> > >
> > > Reported-by: Hulk Robot <hulkci@huawei.com>
> > > Fixes: ff32fac00d97("NTB: EPF: support NTB transfer between PCI RC and
> EP
> > > connection")
> > > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
> > > ---
> > [Frank Li] Acked
>
> @Frank: if you use the conventional style, e.g.,
> "Acked-by: Frank Li <frank.li@nxp.com>", tooling like b4 will
> automatically pick it up. Just saying "Acked" is likely to get missed
> or ignored.
Thanks.
Acked-by: Frank Li <frank.li@nxp.com>
> >
> > > drivers/pci/endpoint/functions/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/pci/endpoint/functions/Kconfig
> > > b/drivers/pci/endpoint/functions/Kconfig
> > > index 362555b024e8..9beee4f0f4ee 100644
> > > --- a/drivers/pci/endpoint/functions/Kconfig
> > > +++ b/drivers/pci/endpoint/functions/Kconfig
> > > @@ -29,6 +29,7 @@ config PCI_EPF_NTB
> > > config PCI_EPF_VNTB
> > > tristate "PCI Endpoint NTB driver"
> > > depends on PCI_ENDPOINT
> > > + depends on NTB
> > > select CONFIGFS_FS
> > > help
> > > Select this configuration option to enable the Non-Transparent
> > > --
> > > 2.17.1
> >
next prev parent reply other threads:[~2022-06-23 15:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 8:46 [PATCH -next] NTB: EPF: Fix Kconfig dependency Ren Zhijie
2022-06-23 15:36 ` Frank Li
2022-06-23 15:55 ` Bjorn Helgaas
2022-06-23 15:58 ` Frank Li [this message]
2022-06-24 1:15 ` [EXT] " Ren Zhijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PAXPR04MB91865EE1D156F47DB8D9EE4B88B59@PAXPR04MB9186.eurprd04.prod.outlook.com \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jdmason@kudzu.us \
--cc=kishon@ti.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=renzhijie2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).