From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Marek Vasut <marek.vasut+renesas@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Murray <andrew.murray@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Frank Rowand <frowand.list@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
Jingoo Han <jingoohan1@gmail.com>,
Simon Horman <horms@verge.net.au>,
Shawn Lin <shawn.lin@rock-chips.com>,
Tom Joseph <tjoseph@cadence.com>,
Heiko Stuebner <heiko@sntech.de>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
Lad Prabhakar <prabhakar.csengg@gmail.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: RE: [PATCH v6 07/11] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller
Date: Fri, 3 Apr 2020 08:28:04 +0000 [thread overview]
Message-ID: <TYAPR01MB4544E4658654491BECD7561AD8C70@TYAPR01MB4544.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <1585856319-4380-8-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com>
Hi Prabhakar-san,
Thank you for your patch!
> From: Lad Prabhakar, Sent: Friday, April 3, 2020 4:39 AM
<snip>
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> new file mode 100644
> index 000000000000..07cd5a7325d0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: GPL-2.0
I'm sorry I should have mentioned in the previous review.
This is better like the following.
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
https://patchwork.kernel.org/patch/11459267/#23246825
<snip>
> +examples:
> + - |
> + #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
> + #include <dt-bindings/power/r8a774c0-sysc.h>
> +
> + pcie0_ep: pcie-ep@fe000000 {
> + compatible = "renesas,r8a774c0-pcie-ep",
> + "renesas,rcar-gen3-pcie-ep";
> + reg = <0 0xfe000000 0 0x80000>,
> + <0x0 0xfe100000 0 0x100000>,
> + <0x0 0xfe200000 0 0x200000>,
> + <0x0 0x30000000 0 0x8000000>,
> + <0x0 0x38000000 0 0x8000000>;
Examples are built with #{address,size}-cells = <1>, so
reg = <0xfe000000 0x80000>,
<0xfe100000 0x100000>,
<0xfe200000 0x200000>,
<0x30000000 0x8000000>,
<0x38000000 0x8000000>;
https://patchwork.kernel.org/patch/11459267/#23246825
Best regards,
Yoshihiro Shimoda
next prev parent reply other threads:[~2020-04-03 8:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 19:38 [PATCH v6 00/11] Add support for PCIe controller to work in endpoint mode on R-Car SoCs Lad Prabhakar
2020-04-02 19:38 ` [PATCH v6 01/11] PCI: rcar: Rename pcie-rcar.c to pcie-rcar-host.c Lad Prabhakar
2020-04-03 7:52 ` Yoshihiro Shimoda
2020-04-02 19:38 ` [PATCH v6 02/11] arm64: defconfig: enable CONFIG_PCIE_RCAR_HOST Lad Prabhakar
2020-04-03 8:03 ` Yoshihiro Shimoda
2020-04-03 8:28 ` Geert Uytterhoeven
2020-04-03 9:04 ` Yoshihiro Shimoda
2020-04-03 9:31 ` Prabhakar Mahadev Lad
2020-04-03 9:44 ` Yoshihiro Shimoda
2020-04-02 19:38 ` [PATCH v6 03/11] PCI: drop PCIE_RCAR config option Lad Prabhakar
2020-04-02 19:38 ` [PATCH v6 04/11] PCI: rcar: Move shareable code to a common file Lad Prabhakar
2020-04-03 8:06 ` Yoshihiro Shimoda
2020-04-02 19:38 ` [PATCH v6 05/11] PCI: rcar: Fix calculating mask for PCIEPAMR register Lad Prabhakar
2020-04-02 19:38 ` [PATCH v6 06/11] PCI: endpoint: Add support to handle multiple base for mapping outbound memory Lad Prabhakar
2020-04-03 8:23 ` Yoshihiro Shimoda
2020-04-03 9:11 ` Prabhakar Mahadev Lad
2020-04-03 9:34 ` Yoshihiro Shimoda
2020-04-03 9:47 ` Prabhakar Mahadev Lad
2020-04-02 19:38 ` [PATCH v6 07/11] dt-bindings: PCI: rcar: Add bindings for R-Car PCIe endpoint controller Lad Prabhakar
2020-04-03 8:28 ` Yoshihiro Shimoda [this message]
2020-04-03 9:02 ` Prabhakar Mahadev Lad
2020-04-02 19:38 ` [PATCH v6 08/11] PCI: rcar: Add support for rcar PCIe controller in endpoint mode Lad Prabhakar
2020-04-03 8:44 ` Yoshihiro Shimoda
2020-04-03 8:58 ` Prabhakar Mahadev Lad
2020-04-02 19:38 ` [PATCH v6 09/11] PCI: Add Renesas R8A774C0 device ID Lad Prabhakar
2020-04-03 8:46 ` Yoshihiro Shimoda
2020-04-02 19:38 ` [PATCH v6 10/11] misc: pci_endpoint_test: Add Device ID for RZ/G2E PCIe controller Lad Prabhakar
2020-04-03 8:47 ` Yoshihiro Shimoda
2020-04-02 19:38 ` [PATCH v6 11/11] MAINTAINERS: Add file patterns for rcar PCI device tree bindings Lad Prabhakar
2020-04-03 8:48 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=TYAPR01MB4544E4658654491BECD7561AD8C70@TYAPR01MB4544.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=andrew.murray@arm.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=heiko@sntech.de \
--cc=horms@verge.net.au \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=magnus.damm@gmail.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=mark.rutland@arm.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tjoseph@cadence.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).