From: Robert Richter <rric@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Dejin Zheng <zhengdejin5@gmail.com>,
corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, bhelgaas@google.com,
wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
kw@linux.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/4] Introduce pcim_alloc_irq_vectors()
Date: Fri, 19 Feb 2021 12:19:20 +0100 [thread overview]
Message-ID: <YC+euDIrR5apkAqp@rric.localdomain> (raw)
In-Reply-To: <YC5zVHnRog3EX0rl@smile.fi.intel.com>
On 18.02.21 16:01:56, Andy Shevchenko wrote:
> The problem this series solves is an imbalanced API.
This (added) API is bloated and incomplete. It adds functions without
benefit, the only is to have a single pcim alloc function in addition
to the pairing of alloc/free functions. I agree, it is hard to detect
which parts are released if pcim_enable_device() is used.
Additional, you need to go through pcim_release() to add other
pcim_*() functions for everything else that is released there.
Otherwise that new API is still incomplete. But this adds another
bunch of useless functions.
> Christoph IIRC was clear that if we want to use PCI IRQ allocation API the
> caller must know what's going on. Hiding this behind the scenes is not good.
> And this series unhides that.
IMO, this is more a documentation issue. pcim_enable_device() must be
better documented and list all enable/alloc functions that are going
to be released out of the box later.
Even better, make sure everything is managed and thus all of a pci_dev
is released, no matter how it was setup (this could even already be
the case).
In addition you could implement a static code checker.
> Also, you may go and clean up all pci_free_irq_vectors() when
> pcim_enable_device() is called, but I guess you will get painful process and
> rejection in a pile of cases.
Why should something be rejected if it is not correctly freed?
Even if pci_free_irq_vectors() is called, pcim_release() will not
complain if it was already freed before. So using
pci_free_irq_vectors() is ok even in conjunction with
pcim_enable_device().
In the end, let's make sure everything is released in pci_dev if it is
managed and document this.
Thanks,
-Robert
next prev parent reply other threads:[~2021-02-19 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 16:02 [PATCH v3 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 16:02 ` [PATCH v3 1/4] PCI: " Dejin Zheng
2021-02-16 17:53 ` Krzysztof Wilczyński
2021-02-16 16:02 ` [PATCH v3 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 17:10 ` Krzysztof Wilczyński
2021-02-17 10:50 ` Dejin Zheng
2021-02-17 13:44 ` Andy Shevchenko
2021-02-16 16:02 ` [PATCH v3 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-16 17:46 ` Krzysztof Wilczyński
2021-02-17 11:40 ` Dejin Zheng
2021-02-17 13:47 ` Andy Shevchenko
2021-02-18 14:15 ` Dejin Zheng
2021-02-16 16:02 ` [PATCH v3 4/4] i2c: thunderx: " Dejin Zheng
2021-02-16 17:49 ` Krzysztof Wilczyński
2021-02-18 9:36 ` [PATCH v3 0/4] Introduce pcim_alloc_irq_vectors() Robert Richter
2021-02-18 14:01 ` Andy Shevchenko
2021-02-19 11:19 ` Robert Richter [this message]
2021-02-19 13:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YC+euDIrR5apkAqp@rric.localdomain \
--to=rric@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).