From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B43DC433EF for ; Wed, 22 Jun 2022 07:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353024AbiFVHd3 (ORCPT ); Wed, 22 Jun 2022 03:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352760AbiFVHdZ (ORCPT ); Wed, 22 Jun 2022 03:33:25 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D191037019; Wed, 22 Jun 2022 00:33:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9C498B81C62; Wed, 22 Jun 2022 07:33:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 472DDC34114; Wed, 22 Jun 2022 07:33:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655883202; bh=M1TCKnfSCn2e6DiQKtvagYnWwei54N2fJytMMiG7IXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pSqf6pIgJb5tY0/g1FfDd/0M1rMacxbsC81DF8RsUGJMbgZ3pj3GCSQd1iyOUZcDl 0LA3xP/M4MkcezaCvLvgBuVU9I7kZg8dXAQiZDW7A5C0karDS1JjJ9faS6AT9rV5Ym Kj3i9X2LBRSRkigD4D8nq00eRHPWJtiQktrfltCKiNF2BY3bIegK7epE+6yeRuShx7 jD6J8v5EBBgq2penN3HlXwHcXekT2bLPsyK4ZYJyw6RcpdY7pkNyL1F9je5kj6oEB8 qB52jxQ5s/s1ZcAH+PWoGcemNVWI0J6WCBdneXrbnvHzN3zVL96BDCRYe8qrUxDtAQ U2YPRanntYZyg== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1o3urW-0007St-Hf; Wed, 22 Jun 2022 09:33:18 +0200 Date: Wed, 22 Jun 2022 09:33:18 +0200 From: Johan Hovold To: Bjorn Helgaas Cc: Robert Marko , svarbanov@mm-sol.com, agross@kernel.org, bjorn.andersson@linaro.org, lpieralisi@kernel.org, robh@kernel.org, kw@linux.com, bhelgaas@google.com, p.zabel@pengutronix.de, jingoohan1@gmail.com, linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, johan+linaro@kernel.org Subject: Re: [PATCH v2] PCI: qcom: fix IPQ8074 Gen2 support Message-ID: References: <20220621112330.448754-1-robimarko@gmail.com> <20220621203211.GA1330530@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Jun 22, 2022 at 08:49:20AM +0200, Johan Hovold wrote: > On Tue, Jun 21, 2022 at 03:32:11PM -0500, Bjorn Helgaas wrote: > > On Tue, Jun 21, 2022 at 01:23:30PM +0200, Robert Marko wrote: > > > IPQ8074 has one Gen2 and one Gen3 port, currently the Gen2 port will > > > cause the system to hang as its using DBI registers in the .init > > > and those are only accesible after phy_power_on(). > > But I also see DBI register accesses in other .init() functions: > > > > qcom_pcie_init_2_1_0 > > qcom_pcie_init_1_0_0 (oddly out of order) > > qcom_pcie_init_2_3_2 > > qcom_pcie_init_2_4_0 > > > > Why do these accesses not need to be moved? I assume it's because > > pcie->phy is an optional PHY and phy_power_on() does nothing on those > > controllers? > > At least the QMP PHY driver does not implement the PHY power_on op and > instead fires everything up already at phy_init(). That may explain the > difference in behaviour here. Or maybe not, IPQ8074 appears to be using the same PHY driver. Johan