From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D51C31E5B for ; Wed, 19 Jun 2019 16:45:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 48217217F4 for ; Wed, 19 Jun 2019 16:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730165AbfFSQpm (ORCPT ); Wed, 19 Jun 2019 12:45:42 -0400 Received: from ale.deltatee.com ([207.54.116.67]:32814 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726332AbfFSQpm (ORCPT ); Wed, 19 Jun 2019 12:45:42 -0400 Received: from s01061831bf6ec98c.cg.shawcable.net ([68.147.80.180] helo=[192.168.6.132]) by ale.deltatee.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1hddiO-0000wT-MB; Wed, 19 Jun 2019 10:45:41 -0600 To: Nicholas Johnson , "benh@kernel.crashing.org" References: Cc: "linux-pci@vger.kernel.org" , Bjorn Helgaas From: Logan Gunthorpe Message-ID: Date: Wed, 19 Jun 2019 10:45:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 68.147.80.180 X-SA-Exim-Rcpt-To: helgaas@kernel.org, linux-pci@vger.kernel.org, benh@kernel.crashing.org, nicholas.johnson-opensource@outlook.com.au X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [nicholas.johnson-opensource@outlook.com.au: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently] X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2019-06-19 8:01 a.m., Nicholas Johnson wrote: > Hi Ben and Logan, > > It looks like my git send-email has been not working correctly since I > started trying to get these patches accepted. I may have remedied this > now, but I have seen that Logan tried to find these patches and failed. > So as a courtesy until I post PATCH v7 (hopefully correctly, this time), > I am forwarding you the patches. I hope you like them. I would love to > know of any concerns or questions you may have, and / or what happens if > you test them. Thanks and all the best! > > ----- Forwarded message from Nicholas Johnson ----- > > Date: Thu, 23 May 2019 06:29:28 +0800 > From: Nicholas Johnson > To: linux-kernel@vger.kernel.org > Cc: linux-pci@vger.kernel.org, bhelgaas@google.com, mika.westerberg@linux.intel.com, corbet@lwn.net, Nicholas Johnson > Subject: [PATCH v6 4/4] PCI: Add pci=hpmemprefsize parameter to set MMIO_PREF size independently > X-Mailer: git-send-email 2.19.1 > > Add kernel parameter pci=hpmemprefsize=nn[KMG] to control MMIO_PREF size > for PCI hotplug bridges. Makes sense. > Change behaviour of pci=hpmemsize=nn[KMG] to not set MMIO_PREF size if > hpmempref has been specified, rather than controlling both MMIO and > MMIO_PREF sizes unconditionally. I don't think I like that fact that hpmemsize behaves differently if hpmempref size is specfied before it. I'd probably suggest having three parameters: hpmemsize which sets both as it always has, a pref one and a regular one which each set one of parameters. Logan