From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>,
<xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [PATCH] PCI: Mark expected switch fall-throughs
Date: Wed, 20 Mar 2019 19:27:32 +0000 [thread overview]
Message-ID: <b67ab7b5-bb75-4443-1cfc-bb905ac09a15@citrix.com> (raw)
In-Reply-To: <20190320182715.GA9406@embeddedor>
On 20/03/2019 18:27, Gustavo A. R. Silva wrote:
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index 6fa1627ce08d..445b51db75b0 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -222,6 +222,7 @@ static long proc_bus_pci_ioctl(struct file *file, unsigned int cmd,
> }
> /* If arch decided it can't, fall through... */
> #endif /* HAVE_PCI_MMAP */
> + /* fall through */
Surely it would be better to transpose the #endif and its previous line,
than to add a second fallthrough ?
~Andrew
next prev parent reply other threads:[~2019-03-20 19:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 18:27 [PATCH] PCI: Mark expected switch fall-throughs Gustavo A. R. Silva
2019-03-20 19:24 ` Bjorn Helgaas
2019-03-20 19:33 ` Gustavo A. R. Silva
2019-03-20 19:27 ` Andrew Cooper [this message]
2019-03-20 19:41 ` [Xen-devel] " Gustavo A. R. Silva
2019-03-20 20:13 ` Bjorn Helgaas
2019-03-20 20:23 ` Gustavo A. R. Silva
2019-03-25 13:25 ` [Xen-devel] " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b67ab7b5-bb75-4443-1cfc-bb905ac09a15@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=gustavo@embeddedor.com \
--cc=jgross@suse.com \
--cc=keescook@chromium.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).