From: Randy Dunlap <rdunlap@infradead.org>
To: "Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Toan Le <toan@os.amperecomputing.com>,
Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: xgene: Fix a non-compliant kernel-doc
Date: Sat, 8 May 2021 21:38:34 -0700 [thread overview]
Message-ID: <c7d7a532-a3e0-e271-e0cd-b02754b18429@infradead.org> (raw)
In-Reply-To: <20210509030237.368540-1-kw@linux.com>
On 5/8/21 8:02 PM, Krzysztof Wilczyński wrote:
> Correct a non-compliant kernel-doc at the top of the pci-xgene.c file,
> and resolve build time warning related to kernel-doc:
>
> drivers/pci/controller/pci-xgene.c:27: warning: expecting prototype for APM X(). Prototype was for PCIECORE_CTLANDSTATUS() instead
>
> No change to functionality intended.
>
> Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/pci/controller/pci-xgene.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/pci-xgene.c b/drivers/pci/controller/pci-xgene.c
> index 7f503dd4ff81..8dc5140dd80d 100644
> --- a/drivers/pci/controller/pci-xgene.c
> +++ b/drivers/pci/controller/pci-xgene.c
> @@ -1,5 +1,5 @@
> // SPDX-License-Identifier: GPL-2.0+
> -/**
> +/*
> * APM X-Gene PCIe Driver
> *
> * Copyright (c) 2014 Applied Micro Circuits Corporation.
>
--
~Randy
next prev parent reply other threads:[~2021-05-09 4:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 3:02 [PATCH] PCI: xgene: Fix a non-compliant kernel-doc Krzysztof Wilczyński
2021-05-09 4:38 ` Randy Dunlap [this message]
2021-06-03 16:10 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7d7a532-a3e0-e271-e0cd-b02754b18429@infradead.org \
--to=rdunlap@infradead.org \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).