From: Ray Jui <ray.jui@broadcom.com>
To: Andrew Murray <andrew.murray@arm.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Srinath Mannam <srinath.mannam@broadcom.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
linux-pci@vger.kernel.org,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/6] PCI: iproc: Add INTx support with better modeling
Date: Wed, 4 Dec 2019 10:36:31 -0800 [thread overview]
Message-ID: <d07d22bc-5ec2-8a0f-22af-6eb89cd68e55@broadcom.com> (raw)
In-Reply-To: <20191204160729.GJ18399@e119886-lin.cambridge.arm.com>
On 12/4/19 8:07 AM, Andrew Murray wrote:
> On Wed, Dec 04, 2019 at 10:29:51AM +0200, Andy Shevchenko wrote:
>> On Wed, Dec 4, 2019 at 12:09 AM Ray Jui <ray.jui@broadcom.com> wrote:
>>> On 12/3/19 11:27 AM, Andy Shevchenko wrote:
>>>> On Tue, Dec 3, 2019 at 5:55 PM Andrew Murray <andrew.murray@arm.com> wrote:
>>>>> On Tue, Dec 03, 2019 at 10:27:02AM +0530, Srinath Mannam wrote:
>>>>
>>>>>> + /* go through INTx A, B, C, D until all interrupts are handled */
>>>>>> + do {
>>>>>> + status = iproc_pcie_read_reg(pcie, IPROC_PCIE_INTX_CSR);
>>>>>
>>>>> By performing this read once and outside of the do/while loop you may improve
>>>>> performance. I wonder how probable it is to get another INTx whilst handling
>>>>> one?
>>>>
>>>> May I ask how it can be improved?
>>>> One read will be needed any way, and so does this code.
>>>>
>>>
>>> I guess the current code will cause the IPROC_PCIE_INTX_CSR register to
>>> be read TWICE, if it's ever set to start with.
>>>
>>> But then if we do it outside of the while loop, if we ever receive an
>>> interrupt while servicing one, the interrupt will still need to be
>>> serviced, and in this case, it will cause additional context switch
>>> overhead by going out and back in the interrupt context.
>
> Yes it's a trade off - if you dropped the do/while loop and thus had a single
> read you'd reduce the overhead on interrupt handling in every case except
> where another INTx is received whilst in this function. But as you point out
> each time that does happen you'll pay the penalty of a context switch.
>
Exactly, it's a tradeoff between: 1) saving one register read (which is
likely in the 10th of nanosecond range) in all INTx handling; and 2)
saving context switches (which is likely in 10th of microsecond range)
in cases when we have multiple INTx when servicing it.
The current implementation takes 2), which I thought it makes sense.
> I don't have any knowledge of this platform so I have no idea if such a change
> would be good/bad or material. However I thought I'd point it out. Looking at
> the other controller drivers, some handle in a loop and some don't.
>
>
>>>
>>> My take is that it's probably more ideal to leave this portion of code
>>> as it is.
>>
>> Can't we simple drop a do-while completely and leave only
>> for_each_set_bit() loop?
>>
Like both Andrew and I pointed out. There's a tradeoff here. Could you
please help to justify why you favor 1) than 2)?
>
> I'm happy either way.
>
> Thanks,
>
> Andrew Murray
>
>>>
>>>>>> + for_each_set_bit(bit, &status, PCI_NUM_INTX) {
>>>>>> + virq = irq_find_mapping(pcie->irq_domain, bit);
>>>>>> + if (virq)
>>>>>> + generic_handle_irq(virq);
>>>>>> + else
>>>>>> + dev_err(dev, "unexpected INTx%u\n", bit);
>>>>>> + }
>>>>>> + } while ((status & SYS_RC_INTX_MASK) != 0);
>>>>
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
next prev parent reply other threads:[~2019-12-04 18:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 4:57 [PATCH v3 0/6] PAXB INTx support with proper model Srinath Mannam
2019-12-03 4:57 ` [PATCH v3 1/6] dt-bindings: pci: Update iProc PCI binding for INTx support Srinath Mannam
2019-12-03 19:19 ` Rob Herring
2019-12-03 4:57 ` [PATCH v3 2/6] PCI: iproc: Add INTx support with better modeling Srinath Mannam
2019-12-03 15:55 ` Andrew Murray
2019-12-03 19:27 ` Andy Shevchenko
2019-12-03 22:09 ` Ray Jui
2019-12-04 8:29 ` Andy Shevchenko
2019-12-04 16:07 ` Andrew Murray
2019-12-04 18:36 ` Ray Jui [this message]
2019-12-06 9:44 ` Srinath Mannam
2019-12-03 4:57 ` [PATCH v3 3/6] arm: dts: Change PCIe INTx mapping for Cygnus Srinath Mannam
2019-12-03 4:57 ` [PATCH v3 4/6] arm: dts: Change PCIe INTx mapping for NSP Srinath Mannam
2019-12-03 4:57 ` [PATCH v3 5/6] arm: dts: Change PCIe INTx mapping for HR2 Srinath Mannam
2019-12-03 4:57 ` [PATCH v3 6/6] arm64: dts: Change PCIe INTx mapping for NS2 Srinath Mannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d07d22bc-5ec2-8a0f-22af-6eb89cd68e55@broadcom.com \
--to=ray.jui@broadcom.com \
--cc=andrew.murray@arm.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).