From: Sinan Kaya <okaya@kernel.org>
To: "Kuppuswamy,
Sathyanarayanan" <sathyanarayanan.kuppuswamy@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, ashok.raj@intel.com,
Jay Vosburgh <jay.vosburgh@canonical.com>
Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call
Date: Mon, 28 Sep 2020 08:11:37 -0400 [thread overview]
Message-ID: <d508091f-a5a3-1127-6a42-e546532da7b2@kernel.org> (raw)
In-Reply-To: <3bc0fd23-8ddd-32c5-1dd9-4d5209ea68c3@linux.intel.com>
On 9/27/2020 10:43 PM, Kuppuswamy, Sathyanarayanan wrote:
>> 2. no bus reset on NON_FATAL error through AER driver path.
>> This already tells me that you need to split your change into
>> multiple patches.
>>
>> Let's talk about this too. bus reset should be triggered via
>> AER driver before informing the recovery.
> But as per error recovery documentation, any call to
> ->error_detected() or ->mmio_enabled() can request
> PCI_ERS_RESULT_NEED_RESET. So we need to add code
> to do the actual reset before calling ->slot_reset()
> callback. So call to pci_reset_bus() fixes this
> issue.
>
> if (status == PCI_ERS_RESULT_NEED_RESET) {
> + pci_reset_bus(dev);
This part seems to make sense as you already highlighted there is
a TO-DO in the code.
This is an independent change that deserves its own patch.
next prev parent reply other threads:[~2020-09-28 12:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3cad1a07-509b-ef51-f635-71def2ff8293@linux.intel.com>
2020-09-22 23:33 ` [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery() call Bjorn Helgaas
2020-09-22 23:44 ` Kuppuswamy, Sathyanarayanan
2020-09-24 1:15 ` Sinan Kaya
2020-09-24 2:04 ` Kuppuswamy, Sathyanarayanan
2020-09-24 2:16 ` Sinan Kaya
2020-09-24 2:51 ` Kuppuswamy, Sathyanarayanan
2020-09-24 3:13 ` Sinan Kaya
2020-09-24 4:06 ` Kuppuswamy, Sathyanarayanan
2020-09-24 20:52 ` Sinan Kaya
2020-09-25 5:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 16:55 ` Sinan Kaya
2020-09-25 17:11 ` Kuppuswamy, Sathyanarayanan
2020-09-25 17:47 ` Sinan Kaya
2020-09-25 18:16 ` Kuppuswamy, Sathyanarayanan
2020-09-25 18:30 ` Sinan Kaya
2020-09-28 2:43 ` Kuppuswamy, Sathyanarayanan
2020-09-28 8:41 ` Ethan Zhao
2020-09-28 11:17 ` Sinan Kaya
2020-09-28 12:16 ` Sinan Kaya
2020-09-28 17:15 ` Kuppuswamy, Sathyanarayanan
2020-09-28 18:02 ` Sinan Kaya
2020-09-28 18:25 ` Sinan Kaya
2020-09-28 18:32 ` Kuppuswamy, Sathyanarayanan
2020-10-12 5:13 ` Kuppuswamy, Sathyanarayanan
2020-10-12 14:51 ` Sinan Kaya
2020-09-28 12:11 ` Sinan Kaya [this message]
2020-09-25 23:50 ` Sinan Kaya
2020-07-24 19:07 sathyanarayanan.kuppuswamy
2020-09-01 5:41 ` Kuppuswamy, Sathyanarayanan
2020-09-22 18:52 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d508091f-a5a3-1127-6a42-e546532da7b2@kernel.org \
--to=okaya@kernel.org \
--cc=ashok.raj@intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jay.vosburgh@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).