From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E70C38A29 for ; Thu, 16 Apr 2020 06:59:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21547206D6 for ; Thu, 16 Apr 2020 06:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437843AbgDPG7I (ORCPT ); Thu, 16 Apr 2020 02:59:08 -0400 Received: from smtprelay0251.hostedemail.com ([216.40.44.251]:48270 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2436919AbgDPG7C (ORCPT ); Thu, 16 Apr 2020 02:59:02 -0400 X-Greylist: delayed 408 seconds by postgrey-1.27 at vger.kernel.org; Thu, 16 Apr 2020 02:58:58 EDT Received: from smtprelay.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by smtpgrave01.hostedemail.com (Postfix) with ESMTP id B423118019B0E; Thu, 16 Apr 2020 06:52:58 +0000 (UTC) Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 0A616100E7B43; Thu, 16 Apr 2020 06:51:59 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wheel34_84bb3b9f86d3c X-Filterd-Recvd-Size: 3344 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf07.hostedemail.com (Postfix) with ESMTPA; Thu, 16 Apr 2020 06:51:52 +0000 (UTC) Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref' From: Joe Perches To: Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski , Maxime Ripard , Stephen Boyd , Alexandre Torgue , Thierry Reding , Sam Ravnborg , Vinod Koul , Bartosz Golaszewski , Guenter Roeck , Jonathan Cameron , Dmitry Torokhov , Jacek Anaszewski , Pavel Machek , Mauro Carvalho Chehab , Lee Jones , Ulf Hansson , Heiko Stuebner , Andrew Lunn , Florian Fainelli , Linus Walleij , Fabio Estevam , Mark Brown , Bjorn Andersson , Alexandre Belloni , Greg Kroah-Hartman , Amit Kucheria , Daniel Lezcano , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org Date: Wed, 15 Apr 2020 23:49:40 -0700 In-Reply-To: <20200416005549.9683-2-robh@kernel.org> References: <20200416005549.9683-1-robh@kernel.org> <20200416005549.9683-2-robh@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 2020-04-15 at 19:55 -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and '$ref' can be mixed with other > keywords. The json-schema library doesn't yet support this, but the > tooling now does a fixup for this and either way works. > > This has been a constant source of review comments, so let's change this > treewide so everyone copies the simpler syntax. This is a large change. Was this done manually or by some script? If it was done manually, how likely is it there are defects in the conversion?