From: kajoljain <kjain@linux.ibm.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: acme@kernel.org, peterz@infradead.org, mingo@redhat.com,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
pc@us.ibm.com, jolsa@redhat.com, namhyung@kernel.org,
yao.jin@linux.intel.com, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, irogers@google.com,
maddy@linux.ibm.com, ravi.bangoria@linux.ibm.com,
anju@linux.vnet.ibm.com, kan.liang@linux.intel.com,
nasastry@in.ibm.com
Subject: Re: [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events
Date: Tue, 18 Aug 2020 14:46:10 +0530 [thread overview]
Message-ID: <1265e9f4-fcfd-bb21-bf27-4ce56a04bcb9@linux.ibm.com> (raw)
In-Reply-To: <20200816163521.GF1486171@tassilo.jf.intel.com>
On 8/16/20 10:05 PM, Andi Kleen wrote:
>> @@ -321,7 +331,7 @@ static void print_events_table_prefix(FILE *fp, const char *tblname)
>> static int print_events_table_entry(void *data, char *name, char *event,
>> char *desc, char *long_desc,
>> char *pmu, char *unit, char *perpkg,
>> - char *metric_expr,
>> + char *metric_expr, char *aggr_mode,
>> char *metric_name, char *metric_group,
>> char *deprecated, char *metric_constraint)
>
> We should really define a struct now to pass the parameters,
> the callback prototype is getting ridiculous.
>
> I know it's my fault originally, but sorry you probably have to do it
> because you are touching it last.
Hi Andi,
I will look into it.
Thanks,
Kajol Jain
>
> -Andi
>
next prev parent reply other threads:[~2020-08-18 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-16 9:07 [PATCH v5 0/3] powerpc/perf: Add json file support for hv_24x7 core level events Kajol Jain
2020-08-16 9:07 ` [PATCH v5 1/3] perf jevents: Add support for parsing perchip/percore events Kajol Jain
2020-08-16 16:35 ` Andi Kleen
2020-08-18 9:16 ` kajoljain [this message]
2020-08-16 9:07 ` [PATCH v5 2/3] perf/tools: Pass pmu_event structure as a parameter for arch_get_runtimeparam Kajol Jain
2020-08-16 9:07 ` [PATCH v5 3/3] perf/tools/pmu_events/powerpc: Add hv_24x7 core level metric events Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1265e9f4-fcfd-bb21-bf27-4ce56a04bcb9@linux.ibm.com \
--to=kjain@linux.ibm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anju@linux.vnet.ibm.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nasastry@in.ibm.com \
--cc=pc@us.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).