From: Leo Yan <leo.yan@linaro.org>
To: Alexandre Truong <alexandre.truong@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
james.clark@arm.com, John Garry <john.garry@huawei.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH] perf tools: add aarch64 registers to --user-regs
Date: Tue, 1 Dec 2020 11:48:06 +0800 [thread overview]
Message-ID: <20201201034806.GB28939@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <20201201034627.GA28939@leoy-ThinkPad-X240s>
Correct for Will's email address, sorry for spamming.
On Tue, Dec 01, 2020 at 11:46:27AM +0800, Leo Yan wrote:
> On Fri, Nov 27, 2020 at 03:39:23PM +0000, Alexandre Truong wrote:
> > Previously, this command returns no help message on aarch64:
> >
> > -> ./perf record --user-regs=?
> >
> > available registers:
> > Usage: perf record [<options>] [<command>]
> > or: perf record [<options>] -- <command> [<options>]
> >
> > With this change, the registers are listed.
> >
> > -> ./perf record --user-regs=?
> >
> > available registers: x0 x1 x2 x3 x4 x5 x6 x7 x8 x9 x10 x11 x12 x13 x14 x15 x16 x17 x18 x19 x20 x21 x22 x23 x24 x25 x26 x27 x28 x29 lr sp pc
> >
> > It's also now possible to record subsets of registers on aarch64:
> >
> > -> ./perf record --user-regs=x4,x5 ls
> > -> ./perf report --dump-raw-trace
> >
> > 12801163749305260 0xc70 [0x40]: PERF_RECORD_SAMPLE(IP, 0x2): 51956/51956: 0xffffaa6571f0 period: 145785 addr: 0
> > ... user regs: mask 0x30 ABI 64-bit
> > .... x4 0x000000000000006c
> > .... x5 0x0000001001000001
> > ... thread: ls:51956
> > ...... dso: /usr/lib64/ld-2.17.so
>
> Reviewed-by: Leo Yan <leo.yan@linaro.org>
>
> Except this patch for enabling registers on aarch64, it's good to add
> arm32's version in the file arch/arm/util/perf_regs.c.
>
> Just note for a side topic, I checked a bit for the implementation for
> x86/powerpc, you could consider to enable Statically Defined Tracing
> in the perf_regs.c file as well. This can be separate task for
> arm/arm64.
>
> Thanks,
> Leo
>
> > Cc: John Garry <john.garry@huawei.com>
> > Cc: Leo Yan <leo.yan@linaro.org>
> > Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> > Cc: Jiri Olsa <jolsa@redhat.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Signed-off-by: Alexandre Truong <alexandre.truong@arm.com>
> > ---
> > tools/perf/arch/arm64/util/perf_regs.c | 33 ++++++++++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/tools/perf/arch/arm64/util/perf_regs.c b/tools/perf/arch/arm64/util/perf_regs.c
> > index 2833e101a..54efa12fd 100644
> > --- a/tools/perf/arch/arm64/util/perf_regs.c
> > +++ b/tools/perf/arch/arm64/util/perf_regs.c
> > @@ -2,5 +2,38 @@
> > #include "../../../util/perf_regs.h"
> >
> > const struct sample_reg sample_reg_masks[] = {
> > + SMPL_REG(x0, PERF_REG_ARM64_X0),
> > + SMPL_REG(x1, PERF_REG_ARM64_X1),
> > + SMPL_REG(x2, PERF_REG_ARM64_X2),
> > + SMPL_REG(x3, PERF_REG_ARM64_X3),
> > + SMPL_REG(x4, PERF_REG_ARM64_X4),
> > + SMPL_REG(x5, PERF_REG_ARM64_X5),
> > + SMPL_REG(x6, PERF_REG_ARM64_X6),
> > + SMPL_REG(x7, PERF_REG_ARM64_X7),
> > + SMPL_REG(x8, PERF_REG_ARM64_X8),
> > + SMPL_REG(x9, PERF_REG_ARM64_X9),
> > + SMPL_REG(x10, PERF_REG_ARM64_X10),
> > + SMPL_REG(x11, PERF_REG_ARM64_X11),
> > + SMPL_REG(x12, PERF_REG_ARM64_X12),
> > + SMPL_REG(x13, PERF_REG_ARM64_X13),
> > + SMPL_REG(x14, PERF_REG_ARM64_X14),
> > + SMPL_REG(x15, PERF_REG_ARM64_X15),
> > + SMPL_REG(x16, PERF_REG_ARM64_X16),
> > + SMPL_REG(x17, PERF_REG_ARM64_X17),
> > + SMPL_REG(x18, PERF_REG_ARM64_X18),
> > + SMPL_REG(x19, PERF_REG_ARM64_X19),
> > + SMPL_REG(x20, PERF_REG_ARM64_X20),
> > + SMPL_REG(x21, PERF_REG_ARM64_X21),
> > + SMPL_REG(x22, PERF_REG_ARM64_X22),
> > + SMPL_REG(x23, PERF_REG_ARM64_X23),
> > + SMPL_REG(x24, PERF_REG_ARM64_X24),
> > + SMPL_REG(x25, PERF_REG_ARM64_X25),
> > + SMPL_REG(x26, PERF_REG_ARM64_X26),
> > + SMPL_REG(x27, PERF_REG_ARM64_X27),
> > + SMPL_REG(x28, PERF_REG_ARM64_X28),
> > + SMPL_REG(x29, PERF_REG_ARM64_X29),
> > + SMPL_REG(lr, PERF_REG_ARM64_LR),
> > + SMPL_REG(sp, PERF_REG_ARM64_SP),
> > + SMPL_REG(pc, PERF_REG_ARM64_PC),
> > SMPL_REG_END
> > };
> > --
> > 2.23.0
> >
prev parent reply other threads:[~2020-12-01 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 15:39 [PATCH] perf tools: add aarch64 registers to --user-regs Alexandre Truong
2020-11-30 15:54 ` James Clark
2020-11-30 17:30 ` John Garry
2020-11-30 17:41 ` Arnaldo Carvalho de Melo
2020-12-01 3:46 ` Leo Yan
2020-12-01 3:48 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201034806.GB28939@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=alexandre.truong@arm.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).