From: Jiri Slaby <jirislaby@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>, acme@redhat.com
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@redhat.com>,
Kan Liang <kan.liang@linux.intel.com>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py}
Date: Wed, 4 Aug 2021 07:49:36 +0200 [thread overview]
Message-ID: <8c62e5f1-be91-0104-898b-250d9f533f8f@kernel.org> (raw)
In-Reply-To: <d916a46f-91fb-4e11-b72e-b96a73971117@intel.com>
On 03. 08. 21, 13:44, Adrian Hunter wrote:
> On 26/07/21 12:14 pm, Jiri Slaby wrote:
>> The scripts cannot be executed on their own. The python ones were always
>> installed without x permissions, the perl ones fail anyway:
>> BEGIN failed--compilation aborted at /usr/lib/perf-core/scripts/perl/rw-by-pid.pl line 18.
>> so there is no point to have a shebang in them. This causes rpmlint to
>> complain too:
>> W: non-executable-script /usr/lib/perf-core/scripts/perl/rw-by-file.pl 644 /usr/bin/perl -w
>>
>> Hence drop shebangs in them all and remove x permissions in the
>> repository. If anyone wants some of them executable, they need to fix
>> the install scripts first.
>>
>> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Andi Kleen <ak@linux.intel.com>
>> Cc: Ingo Molnar <mingo@redhat.com>
>> Cc: Jiri Olsa <jolsa@redhat.com>
>> Cc: Kan Liang <kan.liang@linux.intel.com>
>> Cc: Leo Yan <leo.yan@linaro.org>
>> Cc: Mark Rutland <mark.rutland@arm.com>
>> Cc: Namhyung Kim <namhyung@kernel.org>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>> tools/perf/scripts/perl/rw-by-file.pl | 1 -
>> tools/perf/scripts/perl/rw-by-pid.pl | 1 -
>> tools/perf/scripts/perl/rwtop.pl | 1 -
>> tools/perf/scripts/perl/wakeup-latency.pl | 1 -
>> tools/perf/scripts/python/exported-sql-viewer.py | 1 -
>
> exported-sql-viewer.py is a standalone executable
That's great, but in fact noone can run it when make-installed as I
stated above:
>> If anyone wants some of them executable, they need to fix
>> the install scripts first.
See:
$(INSTALL) scripts/python/*.py -m 644 -t
'$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python';
thanks,
--
js
suse labs
prev parent reply other threads:[~2021-08-04 5:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 9:14 [PATCH v2 1/2] perf: don't install headers with x permissions Jiri Slaby
2021-07-26 9:14 ` [PATCH 2/2] perf: remove shebang from scripts/{perl,python}/*.{pl,py} Jiri Slaby
2021-08-03 11:44 ` Adrian Hunter
2021-08-04 5:49 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c62e5f1-be91-0104-898b-250d9f533f8f@kernel.org \
--to=jirislaby@kernel.org \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).