From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Lux Aliaga <they@mint.lgbt>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
kishon@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, keescook@chromium.org, tony.luck@intel.com,
gpiccoli@igalia.com
Cc: ~postmarketos/upstreaming@lists.sr.ht,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-scsi@vger.kernel.org, linux-hardening@vger.kernel.org,
phone-devel@vger.kernel.org, martin.botka@somainline.org,
marijn.suijten@somainline.org
Subject: Re: [PATCH v7 4/6] arm64: dts: qcom: sm6125: Add UFS nodes
Date: Wed, 8 Mar 2023 11:17:58 +0100 [thread overview]
Message-ID: <b72d54ac-5152-bc6c-55a9-dd59d32614d6@linaro.org> (raw)
In-Reply-To: <20230306170817.3806-5-they@mint.lgbt>
On 6.03.2023 18:08, Lux Aliaga wrote:
> Adds a UFS host controller node and its corresponding PHY to
> the sm6125 platform.
>
> Signed-off-by: Lux Aliaga <they@mint.lgbt>
> ---
[...]
> + ufs_mem_phy: phy@4807000 {
> + compatible = "qcom,sm6125-qmp-ufs-phy";
> + reg = <0x04807000 0xdb8>;
> +
> + clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>, <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> + clock-names = "ref", "ref_aux";
Please wrap it into
clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
<&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
clock-names = "ref",
"ref_aux";
and resolve the binding/offset situation. Otherwise, LGTM!
Konrad
> +
> + resets = <&ufs_mem_hc 0>;
> + reset-names = "ufsphy";
> +
> + power-domains = <&gcc UFS_PHY_GDSC>;
> +
> + #phy-cells = <0>;
> +
> + status = "disabled";
> + };
> +
> gpi_dma0: dma-controller@4a00000 {
> compatible = "qcom,sm6125-gpi-dma", "qcom,sdm845-gpi-dma";
> reg = <0x04a00000 0x60000>;
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2023-03-08 10:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 17:08 [PATCH v7 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 1/6] dt-bindings: ufs: qcom: Add SM6125 compatible string Lux Aliaga
2023-03-24 8:49 ` Krzysztof Kozlowski
2023-03-06 17:08 ` [PATCH v7 2/6] dt-bindings: phy: Add QMP UFS PHY compatible for SM6125 Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 3/6] phy: qcom-qmp: Add SM6125 UFS PHY support Lux Aliaga
2023-03-08 10:09 ` Konrad Dybcio
2023-03-08 11:02 ` Johan Hovold
2023-03-08 11:15 ` Konrad Dybcio
2023-03-08 11:23 ` Johan Hovold
2023-03-08 11:34 ` Konrad Dybcio
2023-03-08 11:37 ` Lux Aliaga
2023-03-08 13:27 ` Johan Hovold
2023-03-06 17:08 ` [PATCH v7 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Lux Aliaga
2023-03-08 10:17 ` Konrad Dybcio [this message]
2023-03-06 17:08 ` [PATCH v7 5/6] dt-bindings: arm: qcom: Document xiaomi,laurel-sprout board Lux Aliaga
2023-03-06 17:08 ` [PATCH v7 6/6] arm64: dts: qcom: sm6125: Initial support for xiaomi-laurel-sprout Lux Aliaga
2023-04-07 18:51 ` (subset) [PATCH v7 0/6] arm64: dts: qcom: sm6125: UFS and xiaomi-laurel-sprout support Bjorn Andersson
-- strict thread matches above, loose matches on Subject: below --
2023-03-06 16:52 Lux Aliaga
2023-03-06 16:52 ` [PATCH v7 4/6] arm64: dts: qcom: sm6125: Add UFS nodes Lux Aliaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b72d54ac-5152-bc6c-55a9-dd59d32614d6@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=keescook@chromium.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=they@mint.lgbt \
--cc=tony.luck@intel.com \
--cc=vkoul@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).