From: Hans de Goede <hdegoede@redhat.com>
To: Jiaxun Yang <jiaxun.yang@flygoat.com>,
kernel test robot <lkp@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
linux-acpi@vger.kernel.org, devel@acpica.org,
linux-pm@vger.kernel.org
Subject: Re: [pm:bleeding-edge 20/29] drivers/acpi/platform_profile.c:67:33: error: passing 'const struct platform_profile_handler to parameter of type 'struct platform_profile_handler discards qualifiers
Date: Tue, 12 Jan 2021 13:10:19 +0100 [thread overview]
Message-ID: <01442a77-7d87-5a12-d7b8-4fe397a37464@redhat.com> (raw)
In-Reply-To: <106d7891-230f-18e1-1b0f-cb6a62cf0387@flygoat.com>
Hi,
On 1/12/21 1:07 PM, Jiaxun Yang wrote:
> 在 2021/1/12 下午6:42, Hans de Goede 写道:
>> Hi,
>>
>> On 1/8/21 9:52 AM, kernel test robot wrote:
> [...]
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
> [...]
>>> 2 errors generated.
>
> Oops, thanks for the reminder, I should exclude 0day CI from mail filter.
> It's wired that GCC didn't say anything about it.
>
>> Ugh, so that means that the current version of the
>> "ACPI: platform-profile: Pass profile pointer to driver callbacks"
>> patch is no good. Since this is causing compile errors I assume
>> that it will be dropped from the bleeding-edge branch.
>> Is that right Rafael?
>
> I'm not familiar with x86pdx and ACPI workflow.
> Should I resend the patch or send a fixup patch?
I believe a new version of the patch is best, then Rafael can
replace the broken patch. We want to avoid having a commit in
git history which does not compile in some cases, because that
creates problems when git bisecting.
Regards,
Hans
next prev parent reply other threads:[~2021-01-12 12:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 8:52 [pm:bleeding-edge 20/29] drivers/acpi/platform_profile.c:67:33: error: passing 'const struct platform_profile_handler to parameter of type 'struct platform_profile_handler discards qualifiers kernel test robot
2021-01-12 10:42 ` Hans de Goede
2021-01-12 12:07 ` Jiaxun Yang
2021-01-12 12:10 ` Hans de Goede [this message]
2021-01-12 13:49 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01442a77-7d87-5a12-d7b8-4fe397a37464@redhat.com \
--to=hdegoede@redhat.com \
--cc=clang-built-linux@googlegroups.com \
--cc=devel@acpica.org \
--cc=jiaxun.yang@flygoat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).