From: Chanwoo Choi <cw00.choi@samsung.com>
To: Leonard Crestez <leonard.crestez@nxp.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: "Matthias Kaehlcke" <mka@chromium.org>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Saravana Kannan" <saravanak@google.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Georgi Djakov" <georgi.djakov@linaro.org>,
"Abel Vesa" <abel.vesa@nxp.com>, "Jacky Bai" <ping.bai@nxp.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 06/11] PM / QoS: Reorder pm_qos/freq_qos/dev_pm_qos structs
Date: Fri, 1 Nov 2019 11:13:04 +0900 [thread overview]
Message-ID: <072ef916-1753-ddc9-0fe8-7704b85def7a@samsung.com> (raw)
In-Reply-To: <254e9ed653c7d9d866a860673629d02351c1afd8.1572556786.git.leonard.crestez@nxp.com>
Hi Leonard,
Why do you add the new patches on v10 (patch6/7/8)
in this series? If you think that need to update
the pm_qos core, you have to send the new patchset
on separate mail thread. It make the difficult
to merge the PM_QoS support of devfreq.
Please split out the patch6/7/8 from this series.
On 19. 11. 1. 오전 6:34, Leonard Crestez wrote:
> This allows dev_pm_qos to embed freq_qos structs, which is done in the
> next patch. Separate commit to make it easier to review.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---
> include/linux/pm_qos.h | 74 ++++++++++++++++++++++--------------------
> 1 file changed, 38 insertions(+), 36 deletions(-)
>
> diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
> index c35ff21e8a40..a8e1486e3200 100644
> --- a/include/linux/pm_qos.h
> +++ b/include/linux/pm_qos.h
> @@ -47,25 +47,10 @@ struct pm_qos_request {
> struct pm_qos_flags_request {
> struct list_head node;
> s32 flags; /* Do not change to 64 bit */
> };
>
> -enum dev_pm_qos_req_type {
> - DEV_PM_QOS_RESUME_LATENCY = 1,
> - DEV_PM_QOS_LATENCY_TOLERANCE,
> - DEV_PM_QOS_FLAGS,
> -};
> -
> -struct dev_pm_qos_request {
> - enum dev_pm_qos_req_type type;
> - union {
> - struct plist_node pnode;
> - struct pm_qos_flags_request flr;
> - } data;
> - struct device *dev;
> -};
> -
> enum pm_qos_type {
> PM_QOS_UNITIALIZED,
> PM_QOS_MAX, /* return the largest value */
> PM_QOS_MIN, /* return the smallest value */
> PM_QOS_SUM /* return the sum */
> @@ -88,10 +73,48 @@ struct pm_qos_constraints {
> struct pm_qos_flags {
> struct list_head list;
> s32 effective_flags; /* Do not change to 64 bit */
> };
>
> +
> +#define FREQ_QOS_MIN_DEFAULT_VALUE 0
> +#define FREQ_QOS_MAX_DEFAULT_VALUE (-1)
> +
> +enum freq_qos_req_type {
> + FREQ_QOS_MIN = 1,
> + FREQ_QOS_MAX,
> +};
> +
> +struct freq_constraints {
> + struct pm_qos_constraints min_freq;
> + struct blocking_notifier_head min_freq_notifiers;
> + struct pm_qos_constraints max_freq;
> + struct blocking_notifier_head max_freq_notifiers;
> +};
> +
> +struct freq_qos_request {
> + enum freq_qos_req_type type;
> + struct plist_node pnode;
> + struct freq_constraints *qos;
> +};
> +
> +
> +enum dev_pm_qos_req_type {
> + DEV_PM_QOS_RESUME_LATENCY = 1,
> + DEV_PM_QOS_LATENCY_TOLERANCE,
> + DEV_PM_QOS_FLAGS,
> +};
> +
> +struct dev_pm_qos_request {
> + enum dev_pm_qos_req_type type;
> + union {
> + struct plist_node pnode;
> + struct pm_qos_flags_request flr;
> + } data;
> + struct device *dev;
> +};
> +
> struct dev_pm_qos {
> struct pm_qos_constraints resume_latency;
> struct pm_qos_constraints latency_tolerance;
> struct pm_qos_flags flags;
> struct dev_pm_qos_request *resume_latency_req;
> @@ -253,31 +276,10 @@ static inline s32 dev_pm_qos_raw_resume_latency(struct device *dev)
> {
> return PM_QOS_RESUME_LATENCY_NO_CONSTRAINT;
> }
> #endif
>
> -#define FREQ_QOS_MIN_DEFAULT_VALUE 0
> -#define FREQ_QOS_MAX_DEFAULT_VALUE (-1)
> -
> -enum freq_qos_req_type {
> - FREQ_QOS_MIN = 1,
> - FREQ_QOS_MAX,
> -};
> -
> -struct freq_constraints {
> - struct pm_qos_constraints min_freq;
> - struct blocking_notifier_head min_freq_notifiers;
> - struct pm_qos_constraints max_freq;
> - struct blocking_notifier_head max_freq_notifiers;
> -};
> -
> -struct freq_qos_request {
> - enum freq_qos_req_type type;
> - struct plist_node pnode;
> - struct freq_constraints *qos;
> -};
> -
> static inline int freq_qos_request_active(struct freq_qos_request *req)
> {
> return !IS_ERR_OR_NULL(req->qos);
> }
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-11-01 2:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 21:34 [PATCH v10] PM / devfreq: Add dev_pm_qos support Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 01/11] PM / devfreq: Fix devfreq_notifier_call returning errno Leonard Crestez
2019-11-11 5:55 ` Chanwoo Choi
2019-10-31 21:34 ` [PATCH v10 02/11] PM / devfreq: Set scaling_max_freq to max on OPP notifier error Leonard Crestez
2019-11-11 5:55 ` Chanwoo Choi
2019-10-31 21:34 ` [PATCH v10 03/11] PM / devfreq: Split device_register usage Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 04/11] PM / devfreq: Move more initialization before registration Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 05/11] PM / devfreq: Don't take lock in devfreq_add_device Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 06/11] PM / QoS: Reorder pm_qos/freq_qos/dev_pm_qos structs Leonard Crestez
2019-11-01 2:13 ` Chanwoo Choi [this message]
2019-11-01 14:45 ` Leonard Crestez
2019-11-11 5:52 ` Chanwoo Choi
2019-10-31 21:34 ` [PATCH v10 07/11] PM / QoS: Export _freq_qos_apply Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 08/11] PM / QoS: Restore DEV_PM_QOS_MIN/MAX_FREQUENCY Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 09/11] PM / devfreq: Introduce get_freq_range helper Leonard Crestez
2019-11-11 5:56 ` Chanwoo Choi
2019-11-11 14:37 ` Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 10/11] PM / devfreq: Add PM QoS support Leonard Crestez
2019-10-31 21:34 ` [PATCH v10 11/11] PM / devfreq: Use PM QoS for sysfs min/max_freq Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=072ef916-1753-ddc9-0fe8-7704b85def7a@samsung.com \
--to=cw00.choi@samsung.com \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).