From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 08/24] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start
Date: Tue, 16 Jul 2019 21:11:43 +0900 [thread overview]
Message-ID: <17d965c5-4114-4143-30c9-54cd88f9eff3@samsung.com> (raw)
In-Reply-To: <20190707223303.6755-9-digetx@gmail.com>
Hi Dmitiry,
On 19. 7. 8. 오전 7:32, Dmitry Osipenko wrote:
> There is no point in receiving of the notifications while governor is
> stopped, let's keep them disabled like we do for the CPU freq-change
> notifications. This also fixes a potential use-after-free bug if
> notification happens after device's removal.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 33 ++++++++++++++++++-------------
> 1 file changed, 19 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
> index 48a799fa5f63..d5d04c25023b 100644
> --- a/drivers/devfreq/tegra30-devfreq.c
> +++ b/drivers/devfreq/tegra30-devfreq.c
> @@ -576,6 +576,19 @@ static int tegra_actmon_start(struct tegra_devfreq *tegra)
> actmon_writel(tegra, ACTMON_SAMPLING_PERIOD - 1,
> ACTMON_GLB_PERIOD_CTRL);
>
> + /*
> + * CLK notifications are needed in order to reconfigure the upper
> + * consecutive watermark in accordance to the actual clock rate
> + * to avoid unnecessary upper interrupts.
> + */
> + err = clk_notifier_register(tegra->emc_clock,
> + &tegra->clk_rate_change_nb);
> + if (err) {
> + dev_err(tegra->devfreq->dev.parent,
> + "Failed to register rate change notifier\n");
> + return err;
> + }
> +
> for (i = 0; i < ARRAY_SIZE(tegra->devices); i++)
> tegra_actmon_configure_device(tegra, &tegra->devices[i]);
>
> @@ -602,6 +615,8 @@ static int tegra_actmon_start(struct tegra_devfreq *tegra)
> for (i = 0; i < ARRAY_SIZE(tegra->devices); i++)
> tegra_actmon_stop_device(&tegra->devices[i]);
>
> + clk_notifier_unregister(tegra->emc_clock, &tegra->clk_rate_change_nb);
> +
> return err;
> }
>
> @@ -618,6 +633,8 @@ static void tegra_actmon_stop(struct tegra_devfreq *tegra)
>
> for (i = 0; i < ARRAY_SIZE(tegra->devices); i++)
> tegra_actmon_stop_device(&tegra->devices[i]);
> +
> + clk_notifier_unregister(tegra->emc_clock, &tegra->clk_rate_change_nb);
> }
>
> static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> @@ -862,22 +879,14 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
>
> platform_set_drvdata(pdev, tegra);
>
> + tegra->clk_rate_change_nb.notifier_call = tegra_actmon_clk_notify_cb;
> tegra->cpu_rate_change_nb.notifier_call = tegra_actmon_cpu_notify_cb;
> INIT_WORK(&tegra->update_work, tegra_actmon_delayed_update);
>
> - tegra->clk_rate_change_nb.notifier_call = tegra_actmon_clk_notify_cb;
> - err = clk_notifier_register(tegra->emc_clock,
> - &tegra->clk_rate_change_nb);
> - if (err) {
> - dev_err(&pdev->dev,
> - "Failed to register rate change notifier\n");
> - goto remove_opps;
> - }
> -
> err = devfreq_add_governor(&tegra_devfreq_governor);
> if (err) {
> dev_err(&pdev->dev, "Failed to add governor: %d\n", err);
> - goto unreg_notifier;
> + goto remove_opps;
> }
>
> tegra_devfreq_profile.initial_freq = clk_get_rate(tegra->emc_clock);
> @@ -893,9 +902,6 @@ static int tegra_devfreq_probe(struct platform_device *pdev)
> remove_governor:
> devfreq_remove_governor(&tegra_devfreq_governor);
>
> -unreg_notifier:
> - clk_notifier_unregister(tegra->emc_clock, &tegra->clk_rate_change_nb);
> -
> remove_opps:
> dev_pm_opp_remove_all_dynamic(&pdev->dev);
>
> @@ -912,7 +918,6 @@ static int tegra_devfreq_remove(struct platform_device *pdev)
> devfreq_remove_device(tegra->devfreq);
> devfreq_remove_governor(&tegra_devfreq_governor);
>
> - clk_notifier_unregister(tegra->emc_clock, &tegra->clk_rate_change_nb);
> dev_pm_opp_remove_all_dynamic(&pdev->dev);
>
> reset_control_reset(tegra->reset);
>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2019-07-16 12:08 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-07 22:32 [PATCH v4 00/24] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 01/24] PM / devfreq: tegra30: Change irq type to unsigned int Dmitry Osipenko
2019-07-16 11:35 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 02/24] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-07-16 11:47 ` Chanwoo Choi
2019-07-16 13:03 ` Dmitry Osipenko
2019-07-17 6:37 ` Chanwoo Choi
2019-07-17 16:44 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 03/24] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-07-16 11:50 ` Chanwoo Choi
2019-07-16 13:09 ` Dmitry Osipenko
2019-07-17 6:38 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 04/24] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-07-16 11:51 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 05/24] PM / devfreq: tegra30: Set up watermarks properly Dmitry Osipenko
2019-07-18 10:17 ` Chanwoo Choi
2019-07-19 0:00 ` Dmitry Osipenko
2019-07-19 1:31 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 06/24] PM / devfreq: tegra30: Tune up boosting thresholds Dmitry Osipenko
2019-07-16 11:55 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 07/24] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-07-16 12:08 ` Chanwoo Choi
2019-07-16 13:18 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 08/24] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-07-16 12:11 ` Chanwoo Choi [this message]
2019-07-07 22:32 ` [PATCH v4 09/24] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-07-16 12:13 ` Chanwoo Choi
2019-07-16 13:19 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 10/24] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-07-16 12:17 ` Chanwoo Choi
2019-07-16 15:17 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 11/24] PM / devfreq: tegra30: Add debug messages Dmitry Osipenko
2019-07-16 12:23 ` Chanwoo Choi
2019-07-16 13:26 ` Dmitry Osipenko
2019-07-17 6:45 ` Chanwoo Choi
2019-07-17 15:46 ` Dmitry Osipenko
2019-07-18 9:07 ` Chanwoo Choi
2019-07-19 1:13 ` Dmitry Osipenko
2019-07-19 1:22 ` Chanwoo Choi
2019-07-19 17:10 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 12/24] PM / devfreq: tegra30: Inline all one-line functions Dmitry Osipenko
2019-07-16 12:26 ` Chanwoo Choi
2019-07-16 13:35 ` Dmitry Osipenko
2019-07-18 9:09 ` Chanwoo Choi
2019-07-19 1:22 ` Dmitry Osipenko
2019-07-19 1:24 ` Chanwoo Choi
2019-07-19 1:27 ` Chanwoo Choi
2019-07-19 2:14 ` Dmitry Osipenko
2019-07-19 6:01 ` Chanwoo Choi
2019-07-19 16:52 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 13/24] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-07-16 12:26 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 14/24] PM / devfreq: tegra30: Ensure that target freq won't overflow Dmitry Osipenko
2019-07-16 12:30 ` Chanwoo Choi
2019-07-16 13:59 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 15/24] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out Dmitry Osipenko
2019-07-16 12:32 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 16/24] PM / devfreq: tegra30: Use kHz units uniformly in the code Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 17/24] PM / devfreq: tegra30: Use tracepoints for debugging Dmitry Osipenko
2019-07-18 9:47 ` Chanwoo Choi
2019-07-19 0:49 ` Dmitry Osipenko
2019-07-19 1:01 ` Chanwoo Choi
2019-07-19 1:50 ` Dmitry Osipenko
2019-07-07 22:32 ` [PATCH v4 18/24] PM / devfreq: tegra30: Optimize CPUFreq notifier Dmitry Osipenko
2019-07-18 9:48 ` Chanwoo Choi
2019-07-19 0:42 ` Dmitry Osipenko
2019-07-19 1:09 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 19/24] PM / devfreq: tegra30: Optimize upper consecutive watermark selection Dmitry Osipenko
2019-07-18 9:51 ` Chanwoo Choi
2019-07-19 0:40 ` Dmitry Osipenko
2019-07-19 1:15 ` Chanwoo Choi
2019-07-19 1:17 ` Chanwoo Choi
2019-07-07 22:32 ` [PATCH v4 20/24] PM / devfreq: tegra30: Optimize upper average " Dmitry Osipenko
2019-07-19 1:36 ` Chanwoo Choi
2019-07-19 1:59 ` Dmitry Osipenko
2019-07-19 2:06 ` Chanwoo Choi
2019-07-19 2:21 ` Dmitry Osipenko
2019-07-19 6:09 ` Chanwoo Choi
2019-07-19 6:11 ` Chanwoo Choi
2019-07-19 17:52 ` Dmitry Osipenko
2019-07-24 11:17 ` Chanwoo Choi
2019-07-24 11:19 ` Chanwoo Choi
2019-07-07 22:33 ` [PATCH v4 21/24] PM / devfreq: tegra30: Synchronize average count on target's update Dmitry Osipenko
2019-07-18 10:15 ` Chanwoo Choi
2019-07-19 0:31 ` Dmitry Osipenko
2019-07-19 1:40 ` Chanwoo Choi
2019-07-19 16:46 ` Dmitry Osipenko
2019-07-07 22:33 ` [PATCH v4 22/24] PM / devfreq: tegra30: Include appropriate header Dmitry Osipenko
2019-07-18 9:58 ` Chanwoo Choi
2019-07-19 0:34 ` Dmitry Osipenko
2019-07-07 22:33 ` [PATCH v4 23/24] PM / devfreq: tegra30: Increase sampling period to 16ms Dmitry Osipenko
2019-07-18 10:00 ` Chanwoo Choi
2019-07-07 22:33 ` [PATCH v4 24/24] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko
2019-07-18 9:56 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17d965c5-4114-4143-30c9-54cd88f9eff3@samsung.com \
--to=cw00.choi@samsung.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).