From: Ezequiel Garcia <ezequiel@collabora.com>
To: Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: kernel@collabora.com, linux-pm@vger.kernel.org,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Ezequiel Garcia <ezequiel@collabora.com>
Subject: [PATCH 2/2] PM / devfreq: Sanitize prints
Date: Wed, 5 Jun 2019 16:00:53 -0300 [thread overview]
Message-ID: <20190605190053.19177-2-ezequiel@collabora.com> (raw)
In-Reply-To: <20190605190053.19177-1-ezequiel@collabora.com>
This commit is a simple cosmetic cleanup, where pr_fmt is used to avoid
the "DEVFREQ" prefix in some prints.
Also, messages are changed to not start with a capital. This is just
a cosmetic change, meant to sanitize all prints from this file.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
drivers/devfreq/devfreq.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 8868ad9472d2..44392fa1c570 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -10,6 +10,8 @@
* published by the Free Software Foundation.
*/
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
#include <linux/kernel.h>
#include <linux/kmod.h>
#include <linux/sched.h>
@@ -59,7 +61,7 @@ static struct devfreq *find_device_devfreq(struct device *dev)
struct devfreq *tmp_devfreq;
if (IS_ERR_OR_NULL(dev)) {
- pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
+ pr_err("%s: invalid parameters\n", __func__);
return ERR_PTR(-EINVAL);
}
WARN(!mutex_is_locked(&devfreq_list_lock),
@@ -208,7 +210,7 @@ static struct devfreq_governor *find_devfreq_governor(const char *name)
struct devfreq_governor *tmp_governor;
if (IS_ERR_OR_NULL(name)) {
- pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
+ pr_err("%s: invalid parameters\n", __func__);
return ERR_PTR(-EINVAL);
}
WARN(!mutex_is_locked(&devfreq_list_lock),
@@ -238,7 +240,7 @@ static struct devfreq_governor *try_then_request_governor(const char *name)
struct devfreq_governor *governor;
if (IS_ERR_OR_NULL(name)) {
- pr_err("DEVFREQ: %s: Invalid parameters\n", __func__);
+ pr_err("%s: invalid parameters\n", __func__);
return ERR_PTR(-EINVAL);
}
WARN(!mutex_is_locked(&devfreq_list_lock),
@@ -1001,7 +1003,7 @@ int devfreq_add_governor(struct devfreq_governor *governor)
int err = 0;
if (!governor) {
- pr_err("%s: Invalid parameters.\n", __func__);
+ pr_err("%s: invalid parameters.\n", __func__);
return -EINVAL;
}
@@ -1066,7 +1068,7 @@ int devfreq_remove_governor(struct devfreq_governor *governor)
int err = 0;
if (!governor) {
- pr_err("%s: Invalid parameters.\n", __func__);
+ pr_err("%s: invalid parameters.\n", __func__);
return -EINVAL;
}
--
2.20.1
next prev parent reply other threads:[~2019-06-05 19:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190605190147epcas1p3e74fba524dfcfc87f7ce3c9569ffaa3f@epcas1p3.samsung.com>
2019-06-05 19:00 ` [PATCH 1/2] PM / devfreq: Fix governor module load failure Ezequiel Garcia
2019-06-05 19:00 ` Ezequiel Garcia [this message]
2019-06-20 7:23 ` [PATCH 2/2] PM / devfreq: Sanitize prints Chanwoo Choi
2019-06-20 14:41 ` Ezequiel Garcia
2019-06-21 2:53 ` Chanwoo Choi
2019-06-05 21:46 ` [PATCH 1/2] PM / devfreq: Fix governor module load failure Enric Balletbo Serra
2019-06-06 13:42 ` Ezequiel Garcia
2019-06-06 13:48 ` Enric Balletbo i Serra
2019-06-20 7:59 ` Chanwoo Choi
2019-06-20 8:04 ` Chanwoo Choi
2019-06-20 15:31 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605190053.19177-2-ezequiel@collabora.com \
--to=ezequiel@collabora.com \
--cc=enric.balletbo@collabora.com \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).