From: Viresh Kumar <viresh.kumar@linaro.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: Anson Huang <Anson.Huang@nxp.com>,
Stephen Boyd <sboyd@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Alexandre Bailon <abailon@baylibre.com>,
Jacky Bai <ping.bai@nxp.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
kernel@pengutronix.de, linux-clk@vger.kernel.org,
linux-imx@nxp.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC] devfreq: Add generic devfreq-dt driver
Date: Thu, 6 Jun 2019 08:45:26 +0530 [thread overview]
Message-ID: <20190606031526.xknv5qdoqufim6tr@vireshk-i7> (raw)
In-Reply-To: <e48d7e3d71166cea20c3c200300e0ffa6d26d085.1559737589.git.leonard.crestez@nxp.com>
On 05-06-19, 15:31, Leonard Crestez wrote:
> +static const struct of_device_id devfreq_dt_of_match[] = {
> + { .compatible = "generic-devfreq", },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, devfreq_dt_of_match);
DT can't contain nodes for any virtual devices, this will have similar
problems to cpufreq-dt. How is this driver going to get probed ? Who
will create the device ?
> +static struct platform_driver devfreq_dt_platdrv = {
> + .probe = devfreq_dt_probe,
> + .shutdown = devfreq_dt_shutdown,
> + .driver = {
> + .name = "devfreq-dt",
> + .of_match_table = of_match_ptr(devfreq_dt_of_match),
> + },
> +};
> +module_platform_driver(devfreq_dt_platdrv);
> +
> +MODULE_DESCRIPTION("Generic devfreq-dt driver");
> +MODULE_LICENSE("GPL v2");
> --
> 2.17.1
--
viresh
next prev parent reply other threads:[~2019-06-06 3:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 12:31 [RFC] devfreq: Add generic devfreq-dt driver Leonard Crestez
2019-06-06 3:15 ` Viresh Kumar [this message]
2019-06-10 22:13 ` Leonard Crestez
2019-06-10 23:48 ` Stephen Boyd
2019-06-11 2:38 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606031526.xknv5qdoqufim6tr@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Anson.Huang@nxp.com \
--cc=abailon@baylibre.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).