From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 18/34] power: supply: bq25890_charger: simplify getting the adapter of a client
Date: Thu, 13 Jun 2019 11:50:57 +0200 [thread overview]
Message-ID: <20190613095057.ycf4dxftudnt5ype@verge.net.au> (raw)
In-Reply-To: <20190608105619.593-19-wsa+renesas@sang-engineering.com>
On Sat, Jun 08, 2019 at 12:55:57PM +0200, Wolfram Sang wrote:
> We have a dedicated pointer for that, so use it. Much easier to read and
> less computation involved.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>
> Please apply to your subsystem tree.
>
> drivers/power/supply/bq25890_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c
> index b2ff82b4707a..d333f2b321b9 100644
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -817,7 +817,7 @@ static int bq25890_fw_probe(struct bq25890_device *bq)
> static int bq25890_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> - struct i2c_adapter *adapter = to_i2c_adapter(client->dev.parent);
> + struct i2c_adapter *adapter = client->adapter;
> struct device *dev = &client->dev;
> struct bq25890_device *bq;
> int ret;
> --
> 2.19.1
>
next prev parent reply other threads:[~2019-06-13 15:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 10:55 [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Wolfram Sang
2019-06-08 10:55 ` [PATCH 16/34] power: supply: bq24190_charger: simplify getting the adapter of a client Wolfram Sang
2019-06-13 9:50 ` Simon Horman
2019-06-08 10:55 ` [PATCH 17/34] power: supply: bq24257_charger: " Wolfram Sang
2019-06-13 9:50 ` Simon Horman
2019-06-08 10:55 ` [PATCH 18/34] power: supply: bq25890_charger: " Wolfram Sang
2019-06-13 9:50 ` Simon Horman [this message]
2019-06-08 10:55 ` [PATCH 19/34] power: supply: max14656_charger_detector: " Wolfram Sang
2019-06-13 9:51 ` Simon Horman
2019-06-08 10:55 ` [PATCH 20/34] power: supply: max17040_battery: " Wolfram Sang
2019-06-13 9:52 ` Simon Horman
2019-06-08 10:56 ` [PATCH 21/34] power: supply: max17042_battery: " Wolfram Sang
2019-06-13 9:52 ` Simon Horman
2019-06-08 10:56 ` [PATCH 22/34] power: supply: rt5033_battery: " Wolfram Sang
2019-06-13 9:52 ` Simon Horman
2019-06-08 10:56 ` [PATCH 23/34] power: supply: rt9455_charger: " Wolfram Sang
2019-06-13 9:52 ` Simon Horman
2019-06-08 10:56 ` [PATCH 24/34] power: supply: sbs-manager: " Wolfram Sang
2019-06-13 9:53 ` Simon Horman
2019-06-09 16:37 ` [PATCH 00/34] treewide: simplify getting the adapter of an I2C client Peter Rosin
2019-06-10 7:15 ` Wolfram Sang
2019-06-27 18:28 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613095057.ycf4dxftudnt5ype@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).