From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org
Subject: Re: [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions
Date: Fri, 14 Jun 2019 07:05:47 +0200 [thread overview]
Message-ID: <20190614050547.GA8952@kroah.com> (raw)
In-Reply-To: <b0e6c04d-143f-1b42-0536-028adc9a55a5@linaro.org>
On Thu, Jun 13, 2019 at 10:18:13PM +0200, Daniel Lezcano wrote:
> On 13/06/2019 20:37, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
>
> Sorry if I'm missing some context but does it mean we do no longer take
> care of roll-backing anything?
Yes, but how can that happen here?
> It is acceptable to have half of the debugfs set for example?
Yes, your code should never care about this.
> Or a parent failing to create and the children polluting the root
> debugfs dir because the parent is NULL?
How can the parent be NULL? Remember, debugfs_create_dir() can never
return NULL, so that should not happen. And even if it does, that's
fine, who cares :)
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-14 5:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 18:37 [PATCH] thermal: bcm2835: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-13 20:18 ` Daniel Lezcano
2019-06-14 5:05 ` Greg Kroah-Hartman [this message]
2019-06-14 6:49 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614050547.GA8952@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).