From: Peter Zijlstra <peterz@infradead.org>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Douglas RAILLARD <douglas.raillard@arm.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
viresh.kumar@linaro.org, mingo@redhat.com
Subject: Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching
Date: Mon, 26 Aug 2019 13:24:06 +0200 [thread overview]
Message-ID: <20190826112406.GR2369@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <cb75ae16-727e-636b-2b79-4f049259c0aa@arm.com>
On Mon, Aug 26, 2019 at 11:51:17AM +0200, Dietmar Eggemann wrote:
> Not sure about the extra 'if trace_cpu_frequency_enabled()' but I guess
> it doesn't hurt.
Without that you do that for_each_cpu() iteration unconditionally, even
if the tracepoint is disabled.
next prev parent reply other threads:[~2019-08-26 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 15:33 [PATCH] sched/cpufreq: Align trace event behavior of fast switching Douglas RAILLARD
2019-08-07 20:40 ` Rafael J. Wysocki
2019-08-08 16:18 ` Douglas Raillard
2019-08-26 9:10 ` Rafael J. Wysocki
2019-08-26 9:40 ` Peter Zijlstra
2019-08-26 9:51 ` Dietmar Eggemann
2019-08-26 11:24 ` Peter Zijlstra [this message]
2019-08-26 12:12 ` Dietmar Eggemann
2019-08-28 9:44 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190826112406.GR2369@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dietmar.eggemann@arm.com \
--cc=douglas.raillard@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).