From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Adam Ford" <aford173@gmail.com>,
"André Roth" <neolynx@gmail.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
letux-kernel@openphoenux.org, kernel@pyra-handheld.com
Subject: Re: [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx
Date: Thu, 5 Sep 2019 07:27:34 -0700 [thread overview]
Message-ID: <20190905142734.GV52127@atomide.com> (raw)
In-Reply-To: <a2b56edcada7b9000a6e906387a02c0ee42681db.1567587220.git.hns@goldelico.com>
Hi,
* H. Nikolaus Schaller <hns@goldelico.com> [190904 08:54]:
> According to omap.txt bindings documentation, matching the ti-cpufreq driver needs
> to specify explicitly if a board uses an omap3430 or omap36xx chip.
>
> This needs to add ti,omap3430 to most omap34xx boards and replace ti,omap3630
> by ti,omap36xx for some omap36xx boards (most others already have done it right).
>
> We also clean up some instances of missing ti,am3517 so that we can rely on
> seeing either one of:
>
> ti,am3517
> ti,omap34xx
> ti,omap36xx
>
> in addition to ti,omap3.
Please set up things to use ti,omap3630 in addition to ti,omap36xx
for compatible to avoid churning the same files later.
> diff --git a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts
> --- a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts
> +++ b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts
> @@ -9,5 +9,5 @@
>
> / {
> model = "LogicPD Zoom DM3730 SOM-LV Development Kit";
> - compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap3";
> + compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap36xx", "ti,omap3";
> };
So just make this:
compatible = "logicpd,dm3730-som-lv-devkit", "ti,omap3630", "ti,omap36xx", "ti,omap3";
And so on. It's fine to use ti,omap3630 for 37xx too as they're the same.
> diff --git a/arch/arm/boot/dts/omap3-ldp.dts b/arch/arm/boot/dts/omap3-ldp.dts
> index 9a5fde2d9bce..9947574bd0f8 100644
> --- a/arch/arm/boot/dts/omap3-ldp.dts
> +++ b/arch/arm/boot/dts/omap3-ldp.dts
> @@ -10,7 +10,7 @@
>
> / {
> model = "TI OMAP3430 LDP (Zoom1 Labrador)";
> - compatible = "ti,omap3-ldp", "ti,omap3";
> + compatible = "ti,omap3-ldp", "ti,omap34xx, "ti,omap3";
This fails to compile, it's missing a '"' for ti,omap34xx. And here too,
please update to use:
compatible = "ti,omap3-ldp", "ti,omap3430", "ti,omap34xx", "ti,omap3";
And again it's fine to add "ti,omap3430" for 3530 variants.
Regards,
Tony
next prev parent reply other threads:[~2019-09-05 14:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 8:53 [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 1/3] cpufreq: ti-cpufreq: add support for omap34xx and omap36xx H. Nikolaus Schaller
2019-09-05 14:32 ` Tony Lindgren
2019-09-06 3:01 ` Viresh Kumar
2019-09-06 20:46 ` H. Nikolaus Schaller
2019-09-07 6:34 ` H. Nikolaus Schaller
2019-09-07 7:19 ` [Letux-kernel] " Andreas Kemnade
2019-09-06 3:04 ` Viresh Kumar
2019-09-06 15:49 ` Tony Lindgren
2019-09-04 8:53 ` [RFC v2 2/3] ARM: dts: replace opp-v1 tables by opp-v2 " H. Nikolaus Schaller
2019-09-04 8:53 ` [RFC v2 3/3] ARM: dts: omap3: bulk convert compatible to be explicitly ti,omap3430 or ti,omap36xx H. Nikolaus Schaller
2019-09-05 14:27 ` Tony Lindgren [this message]
2019-09-06 7:53 ` H. Nikolaus Schaller
2019-09-06 15:47 ` Tony Lindgren
2019-09-06 17:08 ` H. Nikolaus Schaller
2019-09-06 17:15 ` H. Nikolaus Schaller
2019-09-06 17:24 ` Tony Lindgren
2019-09-06 17:50 ` H. Nikolaus Schaller
2019-09-06 17:55 ` H. Nikolaus Schaller
2019-09-05 5:03 ` [RFC v2 0/3] OMAP3: convert opp-v1 to opp-v2 and read speed binned / 720MHz grade bits Viresh Kumar
2019-09-05 14:33 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190905142734.GV52127@atomide.com \
--to=tony@atomide.com \
--cc=aford173@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neolynx@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).