From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: linux-pm@vger.kernel.org, agross@kernel.org, digetx@gmail.com,
evgreen@chromium.org, daidavid1@codeaurora.org,
masneyb@onstation.org, sibis@codeaurora.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/5] interconnect: qcom: sdm845: Walk the list safely on node removal
Date: Mon, 2 Dec 2019 09:36:50 -0800 [thread overview]
Message-ID: <20191202173650.GB133384@yoga> (raw)
In-Reply-To: <20191202162133.7089-1-georgi.djakov@linaro.org>
On Mon 02 Dec 08:21 PST 2019, Georgi Djakov wrote:
> As we will remove items off the list using list_del(), we need to use the
> safe version of list_for_each_entry().
>
> Fixes: b5d2f741077a ("interconnect: qcom: Add sdm845 interconnect provider driver")
> Reported-by: Dmitry Osipenko <digetx@gmail.com>
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> v2:
> - Fix the number of parameters that got messed up. (Bjorn)
>
> drivers/interconnect/qcom/sdm845.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/interconnect/qcom/sdm845.c b/drivers/interconnect/qcom/sdm845.c
> index 502a6c22b41e..387267ee9648 100644
> --- a/drivers/interconnect/qcom/sdm845.c
> +++ b/drivers/interconnect/qcom/sdm845.c
> @@ -868,9 +868,9 @@ static int qnoc_remove(struct platform_device *pdev)
> {
> struct qcom_icc_provider *qp = platform_get_drvdata(pdev);
> struct icc_provider *provider = &qp->provider;
> - struct icc_node *n;
> + struct icc_node *n, *tmp;
>
> - list_for_each_entry(n, &provider->nodes, node_list) {
> + list_for_each_entry_safe(n, tmp, &provider->nodes, node_list) {
> icc_node_del(n);
> icc_node_destroy(n->id);
> }
prev parent reply other threads:[~2019-12-02 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 16:21 [PATCH v2 1/5] interconnect: qcom: sdm845: Walk the list safely on node removal Georgi Djakov
2019-12-02 16:21 ` [PATCH v2 2/5] interconnect: qcom: qcs404: " Georgi Djakov
2019-12-02 17:37 ` Bjorn Andersson
2019-12-02 16:21 ` [PATCH v2 3/5] interconnect: qcom: msm8974: " Georgi Djakov
2019-12-02 17:37 ` Bjorn Andersson
2019-12-02 16:21 ` [PATCH v2 4/5] interconnect: Add a common helper for removing all nodes Georgi Djakov
2019-12-02 16:21 ` [PATCH v2 5/5] interconnect: qcom: Use the new common helper for node removal Georgi Djakov
2019-12-02 17:40 ` Bjorn Andersson
2019-12-02 17:36 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202173650.GB133384@yoga \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=daidavid1@codeaurora.org \
--cc=digetx@gmail.com \
--cc=evgreen@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=masneyb@onstation.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).