From: Quentin Perret <qperret@google.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Daniel Kachhap <amit.kachhap@gmail.com>,
Javi Merino <javi.merino@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-kernel@vger.kernel.org, Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util()
Date: Fri, 17 Jul 2020 11:14:38 +0100 [thread overview]
Message-ID: <20200717101438.GA2366103@google.com> (raw)
In-Reply-To: <b051b42f0c4f36d7177978e090c6a85df17922c6.1594707424.git.viresh.kumar@linaro.org>
On Tuesday 14 Jul 2020 at 12:06:53 (+0530), Viresh Kumar wrote:
> /**
> - * get_load() - get load for a cpu since last updated
> + * get_load() - get current load for a cpu
> * @cpufreq_cdev: &struct cpufreq_cooling_device for this cpu
> * @cpu: cpu number
> - * @cpu_idx: index of the cpu in time_in_idle*
> + * @cpu_idx: index of the cpu
> *
> - * Return: The average load of cpu @cpu in percentage since this
> - * function was last called.
> + * Return: The current load of cpu @cpu in percentage.
> */
> static u32 get_load(struct cpufreq_cooling_device *cpufreq_cdev, int cpu,
> int cpu_idx)
> {
> - u32 load;
> - u64 now, now_idle, delta_time, delta_idle;
> - struct time_in_idle *idle_time = &cpufreq_cdev->idle_time[cpu_idx];
> -
> - now_idle = get_cpu_idle_time(cpu, &now, 0);
> - delta_idle = now_idle - idle_time->time;
> - delta_time = now - idle_time->timestamp;
> + unsigned long util = cpu_util_cfs(cpu_rq(cpu));
> + unsigned long max = arch_scale_cpu_capacity(cpu);
Should we subtract the thermal PELT signal from max? I'm worried that
if we don't do that, the load computed in this function will look
artificially small when IPA is capping the max freq, and that we'll
enter a weird oscillating state due to the cyclic dependency here.
Thoughts?
>
> - if (delta_time <= delta_idle)
> - load = 0;
> - else
> - load = div64_u64(100 * (delta_time - delta_idle), delta_time);
> -
> - idle_time->time = now_idle;
> - idle_time->timestamp = now;
> -
> - return load;
> + util = effective_cpu_util(cpu, util, max, ENERGY_UTIL, NULL);
> + return (util * 100) / max;
> }
Thanks,
Quentin
next prev parent reply other threads:[~2020-07-17 10:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 6:36 [PATCH 0/2] cpufreq_cooling: Get effective CPU utilization from scheduler Viresh Kumar
2020-07-14 6:36 ` [PATCH 1/2] sched/core: Rename and move schedutil_cpu_util to core.c Viresh Kumar
2020-07-14 12:52 ` Rafael J. Wysocki
2020-07-14 6:36 ` [PATCH 2/2] thermal: cpufreq_cooling: Reuse effective_cpu_util() Viresh Kumar
2020-07-14 8:23 ` Peter Zijlstra
2020-07-14 13:05 ` Rafael J. Wysocki
2020-07-15 7:32 ` Viresh Kumar
2020-07-15 12:47 ` Rafael J. Wysocki
2020-07-16 11:56 ` Peter Zijlstra
2020-07-16 14:24 ` Lukasz Luba
2020-07-16 15:43 ` Peter Zijlstra
2020-07-17 9:55 ` Lukasz Luba
2020-07-17 9:46 ` Vincent Guittot
2020-07-17 10:30 ` Lukasz Luba
2020-07-17 12:13 ` Vincent Guittot
2020-07-30 6:24 ` Viresh Kumar
2020-07-30 11:16 ` Lukasz Luba
2020-10-19 7:40 ` Viresh Kumar
2020-10-19 11:10 ` Lukasz Luba
2020-10-22 8:32 ` Viresh Kumar
2020-10-22 9:05 ` Peter Zijlstra
2020-10-22 11:06 ` Viresh Kumar
2020-10-22 11:30 ` Rafael J. Wysocki
2020-10-22 11:57 ` Peter Zijlstra
2020-10-22 12:07 ` Rafael J. Wysocki
2020-10-22 11:39 ` Peter Zijlstra
2020-07-17 10:14 ` Quentin Perret [this message]
2020-07-17 10:33 ` Quentin Perret
2020-07-17 10:43 ` Quentin Perret
2020-07-22 9:13 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200717101438.GA2366103@google.com \
--to=qperret@google.com \
--cc=amit.kachhap@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=javi.merino@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).