From: Lina Iyer <ilina@codeaurora.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] cpuidle: governor: export cpuidle_register_governor
Date: Thu, 3 Sep 2020 09:50:14 -0600 [thread overview]
Message-ID: <20200903155014.GB481@codeaurora.org> (raw)
In-Reply-To: <20200903152354.GA481@codeaurora.org>
On Thu, Sep 03 2020 at 09:23 -0600, Lina Iyer wrote:
>On Thu, Sep 03 2020 at 04:35 -0600, Daniel Lezcano wrote:
>>On 02/09/2020 22:57, Lina Iyer wrote:
>>>Commit 83788c0caed3 ("cpuidle: remove unused exports") removed
>>>capability of registering cpuidle governors, which was unused at that
>>>time. By exporting the symbol, let's allow platform specific modules to
>>>register cpuidle governors.
>>
>>That would make sense as that follows the same pattern than the cpufreq
>>framework. However, the unregister part is missing.
>>
>Sure, let me add that too and repost.
>
Looks like there isn't any call to unregister a governor, which seems
fair.
Also, what do you think about exporting cpuidle_governor_latency_req()?
This could prove quite useful for a governor. I could add that in a
repost.
>--Lina
>
>>>Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>>---
>>> drivers/cpuidle/governor.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>>diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
>>>index 29acaf48e575..480ec58cffa9 100644
>>>--- a/drivers/cpuidle/governor.c
>>>+++ b/drivers/cpuidle/governor.c
>>>@@ -102,6 +102,7 @@ int cpuidle_register_governor(struct cpuidle_governor *gov)
>>>
>>> return ret;
>>> }
>>>+EXPORT_SYMBOL_GPL(cpuidle_register_governor);
>>>
>>> /**
>>> * cpuidle_governor_latency_req - Compute a latency constraint for CPU
>>>
>>
>>
>>--
>><http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
>>
>>Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
>><http://twitter.com/#!/linaroorg> Twitter |
>><http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2020-09-03 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 20:57 [PATCH] cpuidle: governor: export cpuidle_register_governor Lina Iyer
2020-09-03 10:35 ` Daniel Lezcano
2020-09-03 15:23 ` Lina Iyer
2020-09-03 15:50 ` Lina Iyer [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-06-30 19:13 Lina Iyer
2020-06-30 20:26 ` Lina Iyer
2020-07-01 8:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200903155014.GB481@codeaurora.org \
--to=ilina@codeaurora.org \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).