From: Viresh Kumar <viresh.kumar@linaro.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org,
linux-pm@vger.kernel.org, amitk@kernel.org, rui.zhang@intel.com,
dietmar.eggemann@arm.com, Chris.Redpath@arm.com,
Beata.Michalska@arm.com, rjw@rjwysocki.net,
amit.kachhap@gmail.com
Subject: Re: [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes
Date: Wed, 23 Jun 2021 08:45:17 +0530 [thread overview]
Message-ID: <20210623031517.tldkue7dcx4bt7gn@vireshk-i7> (raw)
In-Reply-To: <a5d5d6b8-f358-d1d6-86d0-750af76b0cfb@arm.com>
On 22-06-21, 12:07, Lukasz Luba wrote:
> That cpufreq_stats_record_transition() is present only if
> CONFIG_CPU_FREQ_STAT is set. I didn't wanted to be dependent on
> this config.
Right, but you can also update the dummy
cpufreq_stats_record_transition() function as well and you won't
depend on the CONFIG then.
> >
> > Plus don't you need to record this for all policy->cpus instead of
> > just policy->cpu ?
> >
>
> It will be accounted for all cpus in that freq domain. The
> active_stats_cpu_freq_fast_change() implementation uses
> a shared structure (single for whole domain) 'shared_ast':
> _active_stats_cpu_freq_change(ast->shared_ast, freq, ts)
> (from patch 1/4)
Ahh, I missed that then.
--
viresh
next prev parent reply other threads:[~2021-06-23 3:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 7:59 [RFC PATCH 0/4] Introduce Active Stats framework with CPU performance statistics Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 1/4] PM: Introduce Active Stats framework Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 2/4] cpuidle: Add Active Stats calls tracking idle entry/exit Lukasz Luba
2021-06-22 12:33 ` Rafael J. Wysocki
2021-06-22 13:58 ` Lukasz Luba
2021-06-22 14:44 ` Rafael J. Wysocki
2021-06-22 15:02 ` Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 3/4] cpufreq: Add Active Stats calls tracking frequency changes Lukasz Luba
2021-06-22 9:32 ` Viresh Kumar
2021-06-22 11:07 ` Lukasz Luba
2021-06-23 3:15 ` Viresh Kumar [this message]
2021-06-23 9:14 ` Lukasz Luba
2021-06-22 12:28 ` Rafael J. Wysocki
2021-06-22 13:42 ` Lukasz Luba
2021-06-22 13:51 ` Rafael J. Wysocki
2021-06-22 14:09 ` Lukasz Luba
2021-06-22 14:51 ` Rafael J. Wysocki
2021-06-22 14:59 ` Rafael J. Wysocki
2021-06-22 15:10 ` Lukasz Luba
2021-06-22 15:02 ` Lukasz Luba
2021-06-22 7:59 ` [RFC PATCH 4/4] thermal: cpufreq_cooling: Improve power estimation based on Active Stats framework Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210623031517.tldkue7dcx4bt7gn@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=Beata.Michalska@arm.com \
--cc=Chris.Redpath@arm.com \
--cc=amit.kachhap@gmail.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).