From: Stephen Boyd <swboyd@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>,
andy.gross@linaro.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
bjorn.andersson@linaro.org, evgreen@chromium.org,
dianders@chromium.org, rnayak@codeaurora.org,
ilina@codeaurora.org, lsrao@codeaurora.org,
mkshah@codeaurora.org, devicetree@vger.kernel.org,
Mahesh Sivasubramanian <msivasub@codeaurora.org>
Subject: Re: [PATCH 1/2] dt-bindings: Introduce soc sleep stats bindings for Qualcomm SoCs
Date: Thu, 08 Aug 2019 09:20:04 -0700 [thread overview]
Message-ID: <5d4c4bb6.1c69fb81.db640.7518@mx.google.com> (raw)
In-Reply-To: <20190808061228.16573-2-mkshah@codeaurora.org>
Quoting Maulik Shah (2019-08-07 23:12:27)
> Add device binding documentation for Qualcomm Technology Inc's (QTI)
> SoC sleep stats driver. The driver is used for displaying SoC sleep
> statistic maintained by Always On Processor or Resource Power Manager.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian <msivasub@codeaurora.org>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Your SoB chain is odd. The author is Mahesh? Otherwise, use the
Co-Developed-by tag.
> ---
> .../bindings/soc/qcom/soc-sleep-stats.txt | 36 +++++++++++++++++++
> 1 file changed, 36 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
> new file mode 100644
> index 000000000000..ee40687ded34
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/soc-sleep-stats.txt
> @@ -0,0 +1,36 @@
> +* SoC Sleep Stats
> +
> +Always On Processor/Resource Power Manager maintains statistics of the SoC
> +sleep modes involving lowering or powering down of the backbone rails - Cx
What is a 'backbone' rail?
> +and Mx and the oscillator clock, XO.
Drop the comma? XO is the oscillator clock.
> +
> +Statistics includes SoC sleep mode type, number of times low power mode were
> +entered, time of last entry, time of last exit and accumulated sleep duration.
> +SoC Sleep Stats driver provides sysfs interface to display this information.
Can this document be YAML? Then it can be validated.
> +
> +PROPERTIES
> +
> +- compatible:
> + Usage: required
> + Value type: <string>
> + Definition: Should be "qcom,rpmh-sleep-stats" or "qcom,rpm-sleep-stats".
> +
> +- reg:
> + Usage: required
> + Value type: <prop-encoded-array>
> + Definition: The base address on the Always On Processor or Resource Power
> + Manager from where the stats are read.
> +
> +EXAMPLE 1:
> +
> + rpmh_sleep_stats: soc-sleep-stats@c3f0000 {
> + compatible = "qcom,rpmh-sleep-stats";
> + reg = <0 0xc3f0000 0 0x400>;
Is this memory region in DDR? Or some specific IMEM location? I wonder
if it would be better to just have a pointer from the RPM node to this
memory region and then populate some stats if so.
> + };
> +
next prev parent reply other threads:[~2019-08-08 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 6:12 [PATCH 0/2] Introduce SoC sleep stats driver Maulik Shah
2019-08-08 6:12 ` [PATCH 1/2] dt-bindings: Introduce soc sleep stats bindings for Qualcomm SoCs Maulik Shah
2019-08-08 16:20 ` Stephen Boyd [this message]
2020-02-21 5:57 ` Maulik Shah
2019-08-08 6:12 ` [PATCH 2/2] drivers: qcom: Add SoC sleep stats driver Maulik Shah
2019-08-08 18:40 ` Stephen Boyd
2020-02-21 6:04 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4c4bb6.1c69fb81.db640.7518@mx.google.com \
--to=swboyd@chromium.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=msivasub@codeaurora.org \
--cc=rnayak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).