From: Chanwoo Choi <cw00.choi@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Sebastian Reichel <sre@kernel.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v3 2/3] extcon: max14577: Add proper dt-compatible strings
Date: Mon, 25 May 2020 12:35:08 +0900 [thread overview]
Message-ID: <8441253a-c8c9-17be-e2a7-7d96f1369dd5@samsung.com> (raw)
In-Reply-To: <20200522102448.30209-2-m.szyprowski@samsung.com>
Hi Marek,
On 5/22/20 7:24 PM, Marek Szyprowski wrote:
> Add device tree compatible strings and create proper modalias structures
> to let this driver load automatically if compiled as module, because
> max14577 MFD driver creates MFD cells with such compatible strings.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> v3:
> - sorted of_max14577_muic_dt_match
> v2:
> - added .of_match_table pointer
> ---
> drivers/extcon/extcon-max14577.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index 32f663436e6e..03af678ddeba 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -782,9 +782,19 @@ static const struct platform_device_id max14577_muic_id[] = {
> };
> MODULE_DEVICE_TABLE(platform, max14577_muic_id);
>
> +static const struct of_device_id of_max14577_muic_dt_match[] = {
> + { .compatible = "maxim,max14577-muic",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX14577, },
> + { .compatible = "maxim,max77836-muic",
> + .data = (void *)MAXIM_DEVICE_TYPE_MAX77836, },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, of_max14577_muic_dt_match);
> +
> static struct platform_driver max14577_muic_driver = {
> .driver = {
> .name = "max14577-muic",
> + .of_match_table = of_max14577_muic_dt_match,
> },
> .probe = max14577_muic_probe,
> .remove = max14577_muic_remove,
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-05-25 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200522102452eucas1p17c18de8f79e27de96474e5fcad6db5fa@eucas1p1.samsung.com>
2020-05-22 10:24 ` [PATCH v3 1/3] regulator: max14577: Add proper dt-compatible strings Marek Szyprowski
[not found] ` <CGME20200522102455eucas1p24b695b7f6c533681f544be166ea69200@eucas1p2.samsung.com>
2020-05-22 10:24 ` [PATCH v3 2/3] extcon: " Marek Szyprowski
2020-05-25 3:35 ` Chanwoo Choi [this message]
[not found] ` <CGME20200522102455eucas1p13700db68b90ec05bd02d21014b81b656@eucas1p1.samsung.com>
2020-05-22 10:24 ` [PATCH v3 3/3] power: charger: " Marek Szyprowski
2020-05-28 7:59 ` Sebastian Reichel
2020-05-22 11:09 ` [PATCH v3 1/3] regulator: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8441253a-c8c9-17be-e2a7-7d96f1369dd5@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).