From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
linux-kernel@vger.kernel.org,
"open list:CPU FREQUENCY SCALING FRAMEWORK"
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: Print driver name if cpufreq_suspend() fails
Date: Mon, 26 Aug 2019 11:22:56 +0200 [thread overview]
Message-ID: <9030003.WlOONWmqy1@kreacher> (raw)
In-Reply-To: <b534e21b-af00-bbec-2a53-0c3bda8c8ce9@gmail.com>
On Thursday, August 22, 2019 6:21:20 PM CEST Florian Fainelli wrote:
> On 8/21/19 7:42 PM, Viresh Kumar wrote:
> > On 21-08-19, 16:16, Florian Fainelli wrote:
> >> Instead of printing the policy, which is incidentally a kernel pointer,
> >> so with limited interest, print the cpufreq driver name that failed to
> >> be suspend, which is more useful for debugging.
> >>
> >> Fixes: 2f0aea936360 ("cpufreq: suspend governors on system suspend/hibernate")
> >
> > I will drop this tag as this isn't a bug really.
>
> Indeed, that was a bit too trigger happy on my side. Thanks!
Applied without the Fixes tag, thanks!
> >
> >> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> >> ---
> >> drivers/cpufreq/cpufreq.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> >> index c28ebf2810f1..330d789f81fc 100644
> >> --- a/drivers/cpufreq/cpufreq.c
> >> +++ b/drivers/cpufreq/cpufreq.c
> >> @@ -1807,8 +1807,8 @@ void cpufreq_suspend(void)
> >> }
> >>
> >> if (cpufreq_driver->suspend && cpufreq_driver->suspend(policy))
> >> - pr_err("%s: Failed to suspend driver: %p\n", __func__,
> >> - policy);
> >> + pr_err("%s: Failed to suspend driver: %s\n", __func__,
> >> + cpufreq_driver->name);
> >> }
> >>
> >> suspend:
> >
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> >
>
>
>
prev parent reply other threads:[~2019-08-26 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 23:16 [PATCH] cpufreq: Print driver name if cpufreq_suspend() fails Florian Fainelli
2019-08-22 2:42 ` Viresh Kumar
2019-08-22 16:21 ` Florian Fainelli
2019-08-26 9:22 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9030003.WlOONWmqy1@kreacher \
--to=rjw@rjwysocki.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).