From: Evan Green <evgreen@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs
Date: Mon, 24 Aug 2020 20:22:50 -0700 [thread overview]
Message-ID: <CAE=gft4zqA8mwt5UYBrBYNUzF4cQdg7m=Zv48ffe1Pbm1HXv4Q@mail.gmail.com> (raw)
In-Reply-To: <20200729104933.1.If8e80e4c0c7ddf99056f6e726e59505ed4e127f3@changeid>
On Wed, Jul 29, 2020 at 10:50 AM Matthias Kaehlcke <mka@chromium.org> wrote:
>
> For disabled paths the 'interconnect_summary' in debugfs currently shows
> the orginally requested bandwidths. This is confusing, since the bandwidth
> requests aren't active. Instead show the bandwidths for disabled
> paths/requests as zero.
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
Looks good to me. I briefly mulled over the idea of showing the
disabled flag as a separate column, but I can't really think of how
that would be useful.
Reviewed-by: Evan Green <evgreen@chromium.org>
prev parent reply other threads:[~2020-08-25 3:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 17:50 [PATCH] interconnect: Show bandwidth for disabled paths as zero in debugfs Matthias Kaehlcke
2020-08-25 0:08 ` Matthias Kaehlcke
2020-08-27 13:32 ` Georgi Djakov
2020-08-25 3:22 ` Evan Green [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft4zqA8mwt5UYBrBYNUzF4cQdg7m=Zv48ffe1Pbm1HXv4Q@mail.gmail.com' \
--to=evgreen@chromium.org \
--cc=dianders@chromium.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).