linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Enric Balletbo Serra <eballetbo@gmail.com>
To: Michael Nosthoff <committed@heine.so>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
	Brian Norris <briannorris@chromium.org>,
	stable@vger.kernel.org, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH v2] power: supply: sbs-battery: use correct flags field
Date: Tue, 27 Aug 2019 12:43:51 +0200	[thread overview]
Message-ID: <CAFqH_52bMDedbRWkyevriYnCGSDRKHFs7UeygPqD00MpLOFobA@mail.gmail.com> (raw)
In-Reply-To: <20190816073742.26866-1-committed@heine.so>

Hi Michael,

I think that Sebastian is expected to be cc'ed, so adding him
(otherwise he can miss your patch)

Missatge de Michael Nosthoff <committed@heine.so> del dia dv., 16
d’ag. 2019 a les 9:38:
>
> the type flag is stored in the chip->flags field not in the
> client->flags field. This currently leads to never using the ti
> specific health function as client->flags doesn't use that bit.
> So it's always falling back to the general one.
>
> Fixes: 76b16f4cdfb8 ("power: supply: sbs-battery: don't assume
> MANUFACTURER_DATA formats")
>
> Signed-off-by: Michael Nosthoff <committed@heine.so>
> Reviewed-by: Brian Norris <briannorris@chromium.org>
> Cc: <stable@vger.kernel.org>

Found this patch while looking at another issue and LGTM, so in case
this helps the patch landing

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Thanks,
 Enric

> ---
> Changes since v1:
> * Changed comment according to Brian's suggestions
> * Added Fixes tag
> * Added reviewed and cc stable
>
>  drivers/power/supply/sbs-battery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/sbs-battery.c b/drivers/power/supply/sbs-battery.c
> index 048d205d7074..2e86cc1e0e35 100644
> --- a/drivers/power/supply/sbs-battery.c
> +++ b/drivers/power/supply/sbs-battery.c
> @@ -620,7 +620,7 @@ static int sbs_get_property(struct power_supply *psy,
>         switch (psp) {
>         case POWER_SUPPLY_PROP_PRESENT:
>         case POWER_SUPPLY_PROP_HEALTH:
> -               if (client->flags & SBS_FLAGS_TI_BQ20Z75)
> +               if (chip->flags & SBS_FLAGS_TI_BQ20Z75)
>                         ret = sbs_get_ti_battery_presence_and_health(client,
>                                                                      psp, val);
>                 else
> --
> 2.20.1
>

  reply	other threads:[~2019-08-27 10:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16  7:37 [PATCH v2] power: supply: sbs-battery: use correct flags field Michael Nosthoff
2019-08-27 10:43 ` Enric Balletbo Serra [this message]
2019-09-02  7:59 ` Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFqH_52bMDedbRWkyevriYnCGSDRKHFs7UeygPqD00MpLOFobA@mail.gmail.com \
    --to=eballetbo@gmail.com \
    --cc=briannorris@chromium.org \
    --cc=committed@heine.so \
    --cc=linux-pm@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).