From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Xiongfeng Wang <wangxiongfeng2@huawei.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Souvik Chakravarty <Souvik.Chakravarty@arm.com>,
Thanu.Rangarajan@arm.com, Sudeep Holla <Sudeep.Holla@arm.com>,
Hanjun Guo <guohanjun@huawei.com>,
John Garry <john.garry@huawei.com>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 1/2] cpufreq: change '.set_boost' to act on only one policy
Date: Wed, 20 May 2020 12:36:59 +0200 [thread overview]
Message-ID: <CAJZ5v0gooW-qN0s03rU9ksxsNvxU4ZSZgXGSGaEcg-s16TnvUw@mail.gmail.com> (raw)
In-Reply-To: <20200520045911.amww3nm3e7cezcbf@vireshk-i7>
On Wed, May 20, 2020 at 6:59 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> On 19-05-20, 19:41, Xiongfeng Wang wrote:
> > Macro 'for_each_active_policy()' is defined internally. To avoid some
> > cpufreq driver needing this macro to iterate over all the policies in
> > '.set_boost' callback, we redefine '.set_boost' to act on only one
> > policy and pass the policy as an argument.
> > 'cpufreq_boost_trigger_state()' iterate over all the policies to set
> > boost for the system. This is preparation for adding SW BOOST support
> > for CPPC.
> >
> > Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> > ---
> > drivers/cpufreq/acpi-cpufreq.c | 4 ++--
> > drivers/cpufreq/cpufreq.c | 53 +++++++++++++++++++++---------------------
> > include/linux/cpufreq.h | 2 +-
> > 3 files changed, 30 insertions(+), 29 deletions(-)
> >
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index 289e8ce..b0a9eb5 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -126,7 +126,7 @@ static void boost_set_msr_each(void *p_en)
> > boost_set_msr(enable);
> > }
> >
> > -static int set_boost(int val)
> > +static int set_boost(struct cpufreq_policy *policy, int val)
> > {
> > get_online_cpus();
> > on_each_cpu(boost_set_msr_each, (void *)(long)val, 1);
>
> I think (Rafael can confirm), that you need to update this as well. You don't
> need to run for each cpu now, but for each CPU in the policy.
Right, the caller will iterate over policies.
Accordingly, the CPU hotplug locking needs to go to the caller too.
next prev parent reply other threads:[~2020-05-20 10:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 11:41 [RFC PATCH v3 0/2] add SW BOOST support for CPPC Xiongfeng Wang
2020-05-19 11:41 ` [RFC PATCH v3 1/2] cpufreq: change '.set_boost' to act on only one policy Xiongfeng Wang
2020-05-19 11:57 ` Xiongfeng Wang
2020-05-20 4:59 ` Viresh Kumar
2020-05-20 10:36 ` Rafael J. Wysocki [this message]
2020-05-20 10:41 ` Viresh Kumar
2020-05-19 11:41 ` [RFC PATCH v3 2/2] CPPC: add support for SW BOOST Xiongfeng Wang
2020-05-20 5:00 ` Viresh Kumar
2020-05-21 6:25 ` Xiongfeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJZ5v0gooW-qN0s03rU9ksxsNvxU4ZSZgXGSGaEcg-s16TnvUw@mail.gmail.com \
--to=rafael@kernel.org \
--cc=Souvik.Chakravarty@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=Thanu.Rangarajan@arm.com \
--cc=guohanjun@huawei.com \
--cc=john.garry@huawei.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).