From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Zhang Rui <rui.zhang@intel.com>
Cc: rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, srinivas.pandruvada@intel.com
Subject: Re: [PATCH V4 0/2] powercap: Introduce TPMI RAPL PMU support
Date: Tue, 30 Apr 2024 21:13:28 +0200 [thread overview]
Message-ID: <CAJZ5v0jpaa2tp_NF9N=ViSiz3xmY_abREPZQxK1Hk57Wv7ggHg@mail.gmail.com> (raw)
In-Reply-To: <20240428092427.24959-1-rui.zhang@intel.com>
On Sun, Apr 28, 2024 at 11:24 AM Zhang Rui <rui.zhang@intel.com> wrote:
>
> RAPL energy counter MSRs are exposed via perf PMU. But this is done by
> separate code which is not part of RAPL framework, and it cannot be
> reused by other RAPL Interface drivers like TPMI RAPL.
>
> Introduce two new APIs for PMU support in RAPL framework. This allows
> TPMI RAPL PMU support and also makes it possible for future cleanups of
> MSR RAPL PMU code.
>
> Changes since V3:
> - Fix is_rp_pmu_cpu() return value. (Rafael)
> - Following the conversion in other PMU drivers to use
> local64_try_cmpxchg() instead of local64_cmpxchg(). E.g. bcc6ec3d954b
> ("perf/x86/rapl: Use local64_try_cmpxchg in rapl_event_update()"), and
> update with a comment.
>
> Changes since V2:
> - drop patch 1/3 and rebase on PM tree bleeding-edge branch.
> - fix a regression introduced in patch V2 that RAPL PMU is not
> successfully unregisted when unbinding the device. This causes kernel
> calltrace about duplicate PMU name in sysfs when reloading the module.
> Our unit test cases reproduced this but the test framework failed to
> catch it, and now that problem is also fixed.
> - add comment for RAPL PMU implementation details.
> - add comment/document for struct rapl_pmu and rapl_package_pmu_data.
> - remove unneeded global RAPL PMU cpumask.
> - use an array to map RAPL PMU events to RAPL Domains.
> - Other minor improvements.
>
> Changes since V1:
> - remove the MSR RAPL PMU conversion because it is a separate work that
> can be done later.
> - instead of using a flag to indicate the need of PMU support, introduce
> two APIs for the RAPL Interface driver to invoke explicitly.
> - minor code/comments/changelog improvements.
>
> thanks,
> rui
>
> ----------------------------------------------------------------
> Zhang Rui (2):
> powercap: intel_rapl: Introduce APIs for PMU support
> powercap: intel_rapl_tpmi: Enable PMU support
>
> drivers/powercap/intel_rapl_common.c | 582 +++++++++++++++++++++++++++++++++++
> drivers/powercap/intel_rapl_tpmi.c | 3 +
> include/linux/intel_rapl.h | 32 ++
> 3 files changed, 617 insertions(+)
Both patches applied as 6.10 material, thanks!
prev parent reply other threads:[~2024-04-30 19:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 9:24 [PATCH V4 0/2] powercap: Introduce TPMI RAPL PMU support Zhang Rui
2024-04-28 9:24 ` [PATCH V4 1/2] powercap: intel_rapl: Introduce APIs for " Zhang Rui
2024-04-28 9:24 ` [PATCH V4 2/2] powercap: intel_rapl_tpmi: Enable " Zhang Rui
2024-04-30 19:13 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jpaa2tp_NF9N=ViSiz3xmY_abREPZQxK1Hk57Wv7ggHg@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rui.zhang@intel.com \
--cc=srinivas.pandruvada@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).