From: Arnd Bergmann <arnd@arndb.de>
To: Nandor Han <nandor.han@vaisala.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] power: reset: nvmem-reboot-mode: add CONFIG_OF dependency
Date: Mon, 5 Aug 2019 09:48:03 +0200 [thread overview]
Message-ID: <CAK8P3a2_UtCDGG0qtTyTAADh4BoErS_q0PBMGmZ7UUHrQ9Y2ww@mail.gmail.com> (raw)
In-Reply-To: <6aa562a3-effe-12c2-25d8-47ecf583d724@vaisala.com>
On Mon, Aug 5, 2019 at 9:10 AM Nandor Han <nandor.han@vaisala.com> wrote:
>
> On 7/8/19 3:52 PM, Arnd Bergmann wrote:
> > Without CONFIG_OF, we get a build failure in the reboot-mode
> > implementation:
> >
> > drivers/power/reset/reboot-mode.c: In function 'reboot_mode_register':
> > drivers/power/reset/reboot-mode.c:72:2: error: implicit declaration of function 'for_each_property_of_node'; did you mean 'for_each_child_of_node'? [-Werror=implicit-function-declaration]
> > for_each_property_of_node(np, prop) {
> >
> > Add a Kconfig dependency like we have for the other users of
> > CONFIG_REBOOT_MODE.
> >
> > Fixes: 7a78a7f7695b ("power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/power/reset/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig
> > index 8dfb105db391..a564237278ff 100644
> > --- a/drivers/power/reset/Kconfig
> > +++ b/drivers/power/reset/Kconfig
> > @@ -248,6 +248,7 @@ config POWER_RESET_SC27XX
> >
> > config NVMEM_REBOOT_MODE
> > tristate "Generic NVMEM reboot mode driver"
> > + depends on OF
> > select REBOOT_MODE
> > help
> > Say y here will enable reboot mode driver. This will
> >
>
> Wouldn't this be more appropriate to add the "depends on OF" to "config
> REBOOT_MODE" section, since this is an error to `reboot-mode.c` unit?
It's too late for 5.3-stable now, as that would break existing configurations
that won't select REBOOT_MODE themselves, and it adds a bit of complexity,
but we could to it for 5.4 if you think that is necessary.
Arnd
prev parent reply other threads:[~2019-08-05 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 12:52 [PATCH] power: reset: nvmem-reboot-mode: add CONFIG_OF dependency Arnd Bergmann
2019-08-05 7:10 ` Nandor Han
2019-08-05 7:48 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2_UtCDGG0qtTyTAADh4BoErS_q0PBMGmZ7UUHrQ9Y2ww@mail.gmail.com \
--to=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nandor.han@vaisala.com \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).