From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F85C4CECE for ; Tue, 17 Sep 2019 11:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E17A2218AE for ; Tue, 17 Sep 2019 11:46:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfIQLqO (ORCPT ); Tue, 17 Sep 2019 07:46:14 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34736 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbfIQLqO (ORCPT ); Tue, 17 Sep 2019 07:46:14 -0400 Received: by mail-oi1-f195.google.com with SMTP id 83so1059391oii.1; Tue, 17 Sep 2019 04:46:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iQmgkBy929J7xJM6lySEJ2RGnrP3SzRTLUGUYlBX0sU=; b=HwgNTJDKTl31C35oyunoRdG/Gop/nQwSz5Ly4r4I2HZcql8RRQmube18UeMIy0f3y7 v6muIEvnXXb9Z6ClKUcR9uLIvP/GDoWnCOWOi+TPCBXdg8WBRWbiE7SucOFsvc1x8snc W1/HXF/p5Cx9ABpti0Ic2mS+zD+swaNAeNfmEWsTXlClkQOZPAhTMjc5VzeX3k8vsKWA z8lExUfPdBqAmPfWldLYkZYXLseicBJrRtfyN4X9MY+5aSUfuXC49+2RhDRMpci4IM+H HhTITBJXNmG5XBmP2moRfbk7sJyNQOAwVREn2y0UyItRLBPibb6wz/2HGVf7E27915Nh aAQA== X-Gm-Message-State: APjAAAUgaWnM5a0tYAA926/f65r9RSGLAviSRiGRsk9yJs9b7OZ/gwj6 I+qOq0zUxs+UP4xwpchvI6VFxb+5qINYyzeVw4w= X-Google-Smtp-Source: APXvYqzTXjZEVBuKrH039W2b4srrBsE9xr3er4HJXAkLCSJ4cWnd1aTpjOyolHKADv0pTZdfq9cR13pL3FHNTPMA5LY= X-Received: by 2002:aca:dad4:: with SMTP id r203mr3338531oig.102.1568720773071; Tue, 17 Sep 2019 04:46:13 -0700 (PDT) MIME-Version: 1.0 References: <20190916100717.31472-1-horms+renesas@verge.net.au> <20190917113250.6q4mmyiaa7pdkbeb@verge.net.au> <20190917114112.wh564oqhdmfhkm4u@verge.net.au> In-Reply-To: <20190917114112.wh564oqhdmfhkm4u@verge.net.au> From: Geert Uytterhoeven Date: Tue, 17 Sep 2019 13:46:02 +0200 Message-ID: Subject: Re: [PATCH] dt-bindings: thermal: rcar-thermal: convert bindings to json-schema To: Simon Horman Cc: Zhang Rui , Eduardo Valentin , =?UTF-8?Q?Niklas_S=C3=B6derlund?= , Geert Uytterhoeven , Daniel Lezcano , Rob Herring , Mark Rutland , Magnus Damm , Yoshihiro Kaneko , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux-Renesas Content-Type: text/plain; charset="UTF-8" Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Hi Simon, On Tue, Sep 17, 2019 at 1:41 PM Simon Horman wrote: > On Tue, Sep 17, 2019 at 01:37:39PM +0200, Geert Uytterhoeven wrote: > > On Tue, Sep 17, 2019 at 1:32 PM Simon Horman wrote: > > > I missread the original bindings document and somehow missed > > > warnings emitted by dtbs_check. I now think the compat property should be > > > described as: > > > > > > compatible: > > > oneOf: > > > - items: > > > - enum: > > > - renesas,thermal-r8a73a4 # R-Mobile APE6 > > > - renesas,thermal-r8a7779 # R-Car H1 > > > - const: renesas,rcar-thermal # Without thermal-zone > > > > > > - items: > > > - enum: > > > - renesas,thermal-r8a7790 # R-Car H2 > > > - renesas,thermal-r8a7791 # R-Car M2-W > > > - renesas,thermal-r8a7792 # R-Car V2H > > > - renesas,thermal-r8a7793 # R-Car M2-N > > > - const: renesas,rcar-gen2-thermal # With thermal-zone > > > - const: renesas,rcar-thermal # Without thermal-zone > > > > > > - items: > > > - enum: > > > - renesas,thermal-r8a7743 # RZ/G1M > > > - renesas,thermal-r8a7744 # RZ/G1N > > > - const: renesas,rcar-gen2-thermal # With thermal-zone > > > > > > - items: > > > - enum: > > > - renesas,thermal-r8a774c0 # RZ/G2E > > > - renesas,thermal-r8a77970 # R-Car V3M > > > - renesas,thermal-r8a77990 # R-Car E3 > > > - renesas,thermal-r8a77995 # R-Car D3 > > > > Perhaps we should (try to) get rid of the "Without thermal-zone" legacy? > > All R-Car Gen2 DTSes received thermal zones a while ago. > > R-Mobile APE6 and R-Car H1 still don't have them described, though. > > Do you mean deprecate renesas,rcar-thermal ? Exactly. > If so that sounds reasonable if APE6 and R-Car H1 supports thermal-zones. > But I don't feel it belongs in this patch, which aims > to translate the documentation from one format to another OK. > (perhaps highlighting problems along the way :). That part has been activated, definitely ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds